Skip to content

Support/v0.6.3#90

Merged
swethasukumarr merged 3 commits into
support/0.6.3-rcfrom
support/v0.6.3
Jul 9, 2026
Merged

Support/v0.6.3#90
swethasukumarr merged 3 commits into
support/0.6.3-rcfrom
support/v0.6.3

Conversation

@swethasukumarr

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings July 8, 2026 23:51
@github-advanced-security

Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Actions module to handle an Actions.intent / Actions.onIntent backend payload that is a JSON object ({"intent":"...","intentId":N}) rather than a plain string, aligning the OpenRPC fixture and tests with that shape while keeping the public C++ API return type as std::string.

Changes:

  • Introduce a JSON adapter (JsonString) that serializes arbitrary JSON responses into a std::string for the existing C++ API surface.
  • Switch ActionsImpl::intent() and subscribeOnIntent() to use the new adapter and update unit/component tests to validate the object payload fields.
  • Update OpenRPC spec examples/schema for Actions.intent and Actions.onIntent, and add a 0.6.3 changelog entry.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
test/unit/actionsTest.cpp Updates unit test to expect the intent payload as a JSON document encoded in a string.
test/component/actionsGeneratedTest.cpp Updates component test assertions and event trigger payload for object-shaped intent events.
src/json_types/actions.h Adds JsonString adapter to convert JSON responses/events into std::string.
src/actions_impl.cpp Uses JsonString for Actions.intent and Actions.onIntent deserialization.
docs/openrpc/the-spec/firebolt-open-rpc.json Updates the OpenRPC result schemas/examples to reflect object-shaped intent payloads.
CHANGELOG.md Adds 0.6.3 entry describing the fix.

Comment thread src/json_types/actions.h
Comment thread src/json_types/actions.h
Comment thread test/unit/actionsTest.cpp
Comment thread test/component/actionsGeneratedTest.cpp
Comment thread test/component/actionsGeneratedTest.cpp
Comment thread src/actions_impl.cpp
Comment thread CHANGELOG.md
@swethasukumarr swethasukumarr merged commit 82bb32d into support/0.6.3-rc Jul 9, 2026
11 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 9, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants