Support/v0.6.3#90
Merged
Merged
Conversation
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Actions module to handle an Actions.intent / Actions.onIntent backend payload that is a JSON object ({"intent":"...","intentId":N}) rather than a plain string, aligning the OpenRPC fixture and tests with that shape while keeping the public C++ API return type as std::string.
Changes:
- Introduce a JSON adapter (
JsonString) that serializes arbitrary JSON responses into astd::stringfor the existing C++ API surface. - Switch
ActionsImpl::intent()andsubscribeOnIntent()to use the new adapter and update unit/component tests to validate the object payload fields. - Update OpenRPC spec examples/schema for
Actions.intentandActions.onIntent, and add a 0.6.3 changelog entry.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| test/unit/actionsTest.cpp | Updates unit test to expect the intent payload as a JSON document encoded in a string. |
| test/component/actionsGeneratedTest.cpp | Updates component test assertions and event trigger payload for object-shaped intent events. |
| src/json_types/actions.h | Adds JsonString adapter to convert JSON responses/events into std::string. |
| src/actions_impl.cpp | Uses JsonString for Actions.intent and Actions.onIntent deserialization. |
| docs/openrpc/the-spec/firebolt-open-rpc.json | Updates the OpenRPC result schemas/examples to reflect object-shaped intent payloads. |
| CHANGELOG.md | Adds 0.6.3 entry describing the fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.