Skip to content

RDKEMW-20911 : Return full JSON document from Actions.intent/onIntent#87

Merged
swethasukumarr merged 11 commits into
support/0.6.xfrom
feature/RDKEMW-20911
Jul 7, 2026
Merged

RDKEMW-20911 : Return full JSON document from Actions.intent/onIntent#87
swethasukumarr merged 11 commits into
support/0.6.xfrom
feature/RDKEMW-20911

Conversation

@swethasukumarr

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Firebolt C++ Actions module so Actions.intent and Actions.onIntent expose the full intent JSON document (serialized as compact JSON text) rather than returning only the "intent" string, aligning client behavior with the updated Firebolt 9 intent shape.

Changes:

  • Introduces JsonData::JsonString to serialize arbitrary JSON results/events to compact JSON text (json.dump()).
  • Updates ActionsImpl::intent() and subscribeOnIntent() to use the new JSON serializer.
  • Updates unit/component tests and the OpenRPC fixture to expect an intent object ({"intent":"...","intentId":N}), while the C++ API continues returning std::string.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
test/unit/actionsTest.cpp Updates unit expectation to match full intent document being returned (as string).
test/component/actionsGeneratedTest.cpp Updates component expectations and event trigger payload to the new intent document shape.
src/json_types/actions.h Adds JsonString JSON adapter to stringify any JSON value via dump().
src/actions_impl.cpp Switches intent getter and onIntent subscription parsing to JsonString.
docs/openrpc/the-spec/firebolt-open-rpc.json Updates the OpenRPC schema/examples for Actions.intent and Actions.onIntent results to be an object with intent and intentId.

Comment thread test/unit/actionsTest.cpp
Comment thread test/component/actionsGeneratedTest.cpp
Comment thread test/component/actionsGeneratedTest.cpp
Comment thread docs/openrpc/the-spec/firebolt-open-rpc.json
@swethasukumarr swethasukumarr force-pushed the feature/RDKEMW-20911 branch from 8d102db to 618effa Compare July 7, 2026 14:56
@swethasukumarr swethasukumarr changed the base branch from develop to support/0.6.x July 7, 2026 14:56
@swethasukumarr swethasukumarr merged commit b74b854 into support/0.6.x Jul 7, 2026
7 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 7, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants