RDKEMW-20911 : Return full JSON document from Actions.intent/onIntent#87
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Firebolt C++ Actions module so Actions.intent and Actions.onIntent expose the full intent JSON document (serialized as compact JSON text) rather than returning only the "intent" string, aligning client behavior with the updated Firebolt 9 intent shape.
Changes:
- Introduces
JsonData::JsonStringto serialize arbitrary JSON results/events to compact JSON text (json.dump()). - Updates
ActionsImpl::intent()andsubscribeOnIntent()to use the new JSON serializer. - Updates unit/component tests and the OpenRPC fixture to expect an intent object (
{"intent":"...","intentId":N}), while the C++ API continues returningstd::string.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| test/unit/actionsTest.cpp | Updates unit expectation to match full intent document being returned (as string). |
| test/component/actionsGeneratedTest.cpp | Updates component expectations and event trigger payload to the new intent document shape. |
| src/json_types/actions.h | Adds JsonString JSON adapter to stringify any JSON value via dump(). |
| src/actions_impl.cpp | Switches intent getter and onIntent subscription parsing to JsonString. |
| docs/openrpc/the-spec/firebolt-open-rpc.json | Updates the OpenRPC schema/examples for Actions.intent and Actions.onIntent results to be an object with intent and intentId. |
satlead
approved these changes
Jul 6, 2026
…82) * RDKEMW-14887 : Update Stats.memoryUsage api to return value in bytes * RDKEMW-14887 : Fix spacing issues * address copilot comment * clang format fix --------- Co-authored-by: rajanika <rajanikatsr@gmail.com> Co-authored-by: rradha446 <rajanika_radhakrishnan@comcast.com>
8d102db to
618effa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.