RDKEMW-17486 : Add dolbyAtmosExperienceAvailable getter and event sub…#86
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new Device API surface for querying and subscribing to Dolby Atmos experience availability, and wires it through implementation and OpenRPC fixtures so unit/component tests and the demo app can exercise it.
Changes:
- Added
Device.dolbyAtmosExperienceAvailablegetter to the publicIDeviceinterface andDeviceImpl. - Added
Device.onDolbyAtmosExperienceAvailableChangedsubscription API toIDevice/DeviceImplplus unit/component coverage. - Updated OpenRPC spec fixtures (current + legacy + app notifier) and the API demo app to include the new method.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
include/firebolt/device.h |
Extends the public IDevice interface with the new getter and subscription API. |
src/device_impl.h |
Declares the new DeviceImpl overrides for the added IDevice methods. |
src/device_impl.cpp |
Implements the getter via helper_.get<Boolean> and the event subscription via subscriptionManager_. |
test/unit/deviceTest.cpp |
Adds unit tests for success/bad-response paths for the getter and a subscription smoke test. |
test/component/deviceTest.cpp |
Adds component tests for the getter and end-to-end event subscription + event trigger flow. |
test/api_test_app/apis/deviceDemo.cpp |
Exposes the new getter in the demo app’s method list and output. |
docs/openrpc/the-spec/firebolt-open-rpc.json |
Adds the new getter method and event subscription definition with examples/tags. |
docs/openrpc/the-spec/firebolt-open-rpc--legacy.json |
Mirrors the getter + subscriber definitions in the legacy OpenRPC fixture. |
docs/openrpc/the-spec/firebolt-app-open-rpc.json |
Adds the app-side notifier definition for the new Device event. |
satlead
previously approved these changes
Jul 1, 2026
swethasukumarr
force-pushed
the
feature/RDKEMW-17486
branch
from
9486694 to
457dad1
Compare
swethasukumarr
force-pushed
the
feature/RDKEMW-17486
branch
from
c76e765 to
444e824
Compare
satlead
approved these changes
Jul 6, 2026
Rajanika
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…scription