Skip to content

RDKB-65709: Integrate baseline changes for XER2 in EthAgent component#69

Open
vysakhav wants to merge 2 commits into
developfrom
feature/xer2_bringup
Open

RDKB-65709: Integrate baseline changes for XER2 in EthAgent component#69
vysakhav wants to merge 2 commits into
developfrom
feature/xer2_bringup

Conversation

@vysakhav

@vysakhav vysakhav commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Reason for change: Incorporate baseline changes for XER2 in ethernet-agent component.
This change is part of initial bringup.
Able to build full stack image
Board is booting up properly and ethernet-agent is running

Test Procedure: Build support for XER2.
Priority:P2
Risks: Low
Signed-off-by: Vysakh A V vysakh.venugopal@sky.uk

BUILD Verification with the custom branch is ok:
Reference: https://gerrit.teamccp.com/#/c/961708/

Reason for change: Incorporate baseline changes for XER2 in
ethernet-agent component.

Test Procedure: Build support for XER2.

Priority:P2
Signed-off-by: Vysakh A V <vysakh.venugopal@sky.uk>
Copilot AI review requested due to automatic review settings July 15, 2026 09:11
@vysakhav
vysakhav requested review from a team as code owners July 15, 2026 09:11

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Integrates XER2-specific baseline behavior into the Ethernet Agent TR-181 implementation by adjusting product-gated code paths to align XER2 with existing platform handling during initial bring-up.

Changes:

  • Treat XER2 as a platform where DOCSIS operational mode is not supported in EthernetWAN_SetParamStringValue.
  • Update ethGetPHYRate() and EthWanBridgeInit() product gating to include/exclude _XER2_PRODUCT_REQ_ alongside other platform macros.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
source/TR-181/middle_layer_src/cosa_ethernet_dml.c Extends product gating for DOCSIS operational mode selection to include XER2.
source/TR-181/board_sbapi/cosa_ethernet_apis.c Adds XER2 into platform-conditional logic for PHY rate retrieval and EthWAN bridge initialization behavior.
Comments suppressed due to low confidence (1)

source/TR-181/middle_layer_src/cosa_ethernet_dml.c:760

  • The #else branch now also applies to XER2_PRODUCT_REQ (and already applied to other non-DOCSIS platforms), but the warning message still says "XER5/XER10" only. This will be misleading when a XER2 build rejects "DOCSIS" as the SelectedOperationalMode.
	#else
	     CcspTraceWarning(("DOCSIS operationalMode is not supported in XER5/XER10 platform\n"));
             return FALSE;
	#endif

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants