RDKB-65709: Integrate baseline changes for XER2 in EthAgent component#69
Open
vysakhav wants to merge 2 commits into
Open
RDKB-65709: Integrate baseline changes for XER2 in EthAgent component#69vysakhav wants to merge 2 commits into
vysakhav wants to merge 2 commits into
Conversation
Reason for change: Incorporate baseline changes for XER2 in ethernet-agent component. Test Procedure: Build support for XER2. Priority:P2 Signed-off-by: Vysakh A V <vysakh.venugopal@sky.uk>
Contributor
There was a problem hiding this comment.
Pull request overview
Integrates XER2-specific baseline behavior into the Ethernet Agent TR-181 implementation by adjusting product-gated code paths to align XER2 with existing platform handling during initial bring-up.
Changes:
- Treat XER2 as a platform where DOCSIS operational mode is not supported in
EthernetWAN_SetParamStringValue. - Update
ethGetPHYRate()andEthWanBridgeInit()product gating to include/exclude_XER2_PRODUCT_REQ_alongside other platform macros.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| source/TR-181/middle_layer_src/cosa_ethernet_dml.c | Extends product gating for DOCSIS operational mode selection to include XER2. |
| source/TR-181/board_sbapi/cosa_ethernet_apis.c | Adds XER2 into platform-conditional logic for PHY rate retrieval and EthWAN bridge initialization behavior. |
Comments suppressed due to low confidence (1)
source/TR-181/middle_layer_src/cosa_ethernet_dml.c:760
- The #else branch now also applies to XER2_PRODUCT_REQ (and already applied to other non-DOCSIS platforms), but the warning message still says "XER5/XER10" only. This will be misleading when a XER2 build rejects "DOCSIS" as the SelectedOperationalMode.
#else
CcspTraceWarning(("DOCSIS operationalMode is not supported in XER5/XER10 platform\n"));
return FALSE;
#endif
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
SanthoshGujulvajagadeesh
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Incorporate baseline changes for XER2 in ethernet-agent component.
This change is part of initial bringup.
Able to build full stack image
Board is booting up properly and ethernet-agent is running
Test Procedure: Build support for XER2.
Priority:P2
Risks: Low
Signed-off-by: Vysakh A V vysakh.venugopal@sky.uk
BUILD Verification with the custom branch is ok:
Reference: https://gerrit.teamccp.com/#/c/961708/