RDKBACCL-1485: Verify configurable wan interface in BPI R4#67
Open
anatar818 wants to merge 1 commit into
Open
Conversation
Added logic to handle WAN physical interface name retrieval and configuration for specific platforms.
Contributor
There was a problem hiding this comment.
Pull request overview
Adds platform-specific initialization logic to support a configurable WAN interface name on BPI R4 (and related platforms) during Ethernet agent startup.
Changes:
- Introduces a RaspberryPi/Turris/BPI-R4 init path (when
FEATURE_RDKB_VLAN_MANAGERis not defined) that readswan_physical_ifname, persists/reads it via/nvram/wan_name.txt, and configures a bridge usingip link. - Sets the resulting WAN bridge/interface MAC and enslaves
ETHWAN_DEF_INTF_NAMEunder the configured bridge name.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+3515
to
+3519
| memset(&macAddr,0,sizeof(macaddr_t)); | ||
| getInterfaceMacAddress(&macAddr,wanPhyName); | ||
| memset(wan_mac,0,sizeof(wan_mac)); | ||
| snprintf(wan_mac, sizeof(wan_mac), "%02x:%02x:%02x:%02x:%02x:%02x", macAddr.hw[0], macAddr.hw[1], macAddr.hw[2], | ||
| macAddr.hw[3], macAddr.hw[4], macAddr.hw[5]); |
| { | ||
| fclose(fp); | ||
| fileValue[strcspn(fileValue, "\r\n")] = '\0'; | ||
| if (strcmp(fileValue, out_value) != 0) |
| snprintf(wan_mac, sizeof(wan_mac), "%02x:%02x:%02x:%02x:%02x:%02x", macAddr.hw[0], macAddr.hw[1], macAddr.hw[2], | ||
| macAddr.hw[3], macAddr.hw[4], macAddr.hw[5]); | ||
|
|
||
| v_secure_system("syscfg get wan_physical_ifname > /tmp/wan_name.txt"); |
| #if defined(_PLATFORM_RASPBERRYPI_) || defined(_PLATFORM_TURRIS_) || defined(_PLATFORM_BANANAPI_R4_) || defined(_COSA_QCA_ARM_) | ||
| #if (defined(_PLATFORM_RASPBERRYPI_) || defined(_PLATFORM_TURRIS_) || defined(_PLATFORM_BANANAPI_R4_)) && !defined(FEATURE_RDKB_VLAN_MANAGER) | ||
|
|
||
| char wanPhyName[20] = {0},out_value[20] = {0},fileValue[20] = {0};; |
Comment on lines
+3464
to
+3468
| #if (defined(_PLATFORM_RASPBERRYPI_) || defined(_PLATFORM_TURRIS_) || defined(_PLATFORM_BANANAPI_R4_)) && !defined(FEATURE_RDKB_VLAN_MANAGER) | ||
|
|
||
| char wanPhyName[20] = {0},out_value[20] = {0},fileValue[20] = {0};; | ||
| FILE *fp = NULL; | ||
| macaddr_t macAddr; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Verify configurable wan interface in BPI R4 (ethagent functionality)
Test Procedure: Build and flash the image ,Validate wan functionality for the customized interface name
Risks: None