RDKCOM-5601: RDKBDEV-3459, RDKBACCL-1817 Enhance ethernet agent to support configurable wan fro…#66
Open
manigandanj wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts ethernet-agent initialization logic so BananaPi R4 builds no longer run the WAN interface rename path that would rename lan0 to erouter0, aligning with the stated goal of keeping the original interface name.
Changes:
- Removed
_PLATFORM_BANANAPI_R4_from the platform-specific preprocessor guard that triggers WAN interface rename/down/up operations duringCosaDmlEthInit().
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Looks good to me |
manigandanj
force-pushed
the
vlanmanager_integration
branch
2 times, most recently
from
a774c10 to
c0e9356
Compare
manigandanj
force-pushed
the
vlanmanager_integration
branch
from
c0e9356 to
94262af
Compare
…urable wan from ethernet agent Reason for change: Not renaming lan0 to erouter0 when vlanmanager is enabled Test procedure: Found that BPI is getting internet feed. Risks: Low Signed-off-by: Manigandan Gopalakrishnan <Manigandan_Gopalakrishnan@comcast.com>
manigandanj
force-pushed
the
vlanmanager_integration
branch
from
94262af to
6cbe584
Compare
manigandanj
changed the title
pradeeptakdas
changed the title
snayak002c
approved these changes
Jul 16, 2026
|
📋 PR Format Reminder
Expected: |
| } | ||
| #else | ||
| #if defined(_PLATFORM_RASPBERRYPI_) || defined(_PLATFORM_TURRIS_) || defined(_PLATFORM_BANANAPI_R4_) || defined(_COSA_QCA_ARM_) | ||
| #ifndef FEATURE_RDKB_VLAN_MANAGER /* VLAN Manager owns VLAN/Bridge interface creation; Renaming is not required */ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…m ethernet agent
Reason for change: Not renaming lan0 to erouter0
Test procedure: Found that BPI is getting internet feed.
Risks: Low