RDKCOM-5600: RDKBDEV-3458, RDKBACCL-1785 Upstreaming ccsp-eth-agent patches from meta-rdk-bsp-arm#64
Open
ap934 wants to merge 1 commit into
Open
Conversation
ap934
force-pushed
the
upstream-eth-agent-patches
branch
from
6ebb6d7 to
3dbdebb
Compare
…o Generic code Reason for change: Upstreaming the patches from meta-rdk-bsp-arm layer. Test procedure: Build should pass and all functionality should work Risks: low Signed-off-by: ap934 <akhil_p@comcast.com>
ap934
force-pushed
the
upstream-eth-agent-patches
branch
from
3dbdebb to
0d0ff0d
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR upstreams ccsp-eth-agent changes from the meta-rdk-bsp-arm layer, primarily to improve Generic ARM platform behavior (systemd readiness notification, daemonization behavior) and adjust WAN manager interface sizing/logging.
Changes:
- Add systemd
sd_notify(READY=1)readiness notification on Generic ARM builds. - Skip
daemonize()when running with systemd notifications enabled. - Update Generic ARM
TOTAL_NUMBER_OF_INTERNAL_INTERFACESand improve link-status trigger logging.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| source/TR-181/middle_layer_src/plugin_main_apis.c | Adds systemd notify include + READY notification after Ethernet interface initialization. |
| source/TR-181/board_sbapi/cosa_ethernet_apis.c | Adjusts internal interface count for Generic ARM and enhances link-status trigger logging. |
| source/EthSsp/ssp_main.c | Skips daemonization when systemd notifications are enabled. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ANSC_STATUS retStatus; | ||
| INT IfIndex = -1; | ||
| CcspTraceInfo(("%s.%d Enter \n",__FUNCTION__,__LINE__)); | ||
| CcspTraceInfo(("%s.%d Enter (ifname=%s)\n",__FUNCTION__,__LINE__,ifname)); |
Comment on lines
+80
to
+82
| #if defined(_PLATFORM_GENERICARM_) && defined(USE_SYSTEMD_NOTIFICATIONS) | ||
| #include <systemd/sd-daemon.h> | ||
| #endif |
Comment on lines
+180
to
+182
| #if defined(_PLATFORM_GENERICARM_) && defined(USE_SYSTEMD_NOTIFICATIONS) | ||
| sd_notify(0,"READY=1"); | ||
| #endif |
Comment on lines
+324
to
329
| #if !(defined(_PLATFORM_GENERICARM_) && defined(USE_SYSTEMD_NOTIFICATIONS)) | ||
| if ( bRunAsDaemon ) | ||
| daemonize(); | ||
| #endif | ||
|
|
||
| CcspTraceInfo(("\nAfter daemonize before signal\n")); |
ap934
changed the title
pradeeptakdas
changed the title
|
@ap934 Please address the copilot review comments. if comment is not valid , we need to provide the explanation why it is not valid and resolve the comment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Upstreaming the patches from meta-rdk-bsp-arm layer.
Test procedure: Build should pass and all functionality should work
Risks: low