RDKTV-39509 : [EntOS] [A4K] Mute Fails During YouTube Playback with AppleTV#398
Open
kiruba115 wants to merge 1 commit into
Open
RDKTV-39509 : [EntOS] [A4K] Mute Fails During YouTube Playback with AppleTV#398kiruba115 wants to merge 1 commit into
kiruba115 wants to merge 1 commit into
Conversation
…pple TV via HDMI (CEC FeatureAbort: CEC Version)
Contributor
There was a problem hiding this comment.
Pull request overview
Adds HDMI-CEC “User Control Pressed/Released” handling to the HdmiCecSink plugin and forwards these messages to Thunder notification subscribers, likely to ensure key events (e.g., mute) are properly observed during external device playback scenarios (Apple TV / YouTube).
Changes:
- Add
UserControlPressed/UserControlReleasedprocessing inHdmiCecSinkProcessor. - Fan out new key-press/key-release notifications (
OnKeyPressEvent/OnKeyReleaseEvent) to registeredIHdmiCecSink::INotificationclients. - Bridge these new notifications through the JSON-RPC event layer in
HdmiCecSink’s notification sink.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
HdmiCecSink/HdmiCecSinkImplementation.h |
Declares new CEC processor handlers and notification fan-out helpers for key events. |
HdmiCecSink/HdmiCecSinkImplementation.cpp |
Implements CEC message handling for UserControlPressed/Released and emits corresponding plugin notifications. |
HdmiCecSink/HdmiCecSink.h |
Forwards new key events to Exchange::JHdmiCecSink::Event::* so JSON-RPC subscribers can receive them. |
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RDKTV-39509 : [EntOS] [A4K] Mute Fails During YouTube Playback with A…pple TV via HDMI (CEC FeatureAbort: CEC Version)
version: minor