Add support for COMRPC changes in L2Tests plugin in Testframework repo by smanes0213 · Pull Request #356 · rdkcentral/entservices-inputoutput

smanes0213 · 2026-01-07T08:53:32Z

Reason for change: Add COMRPC Support for L2Tests Plugin
Test Procedure : Run L2 Tests to verify the changes
Version : Major
Risks: Low

…OMRPC branch

Changed -Wno-deprecated-declarations to -Wno-error=deprecated-declarations to allow warnings from Thunder's VirtualInput.h without failing the build.

Copilot

Pull request overview

This PR adds support for COMRPC changes in the L2Tests plugin by updating CI/CD workflow configurations. The changes modify both L1 and L2 test workflows to use temporary development branches and adjust build configurations.

Changes:

Updated repository references to use L2TestPlugin_COMRPC and Test branches instead of develop
Fixed CMake variable name from -DBUILD_TYPE to -DCMAKE_BUILD_TYPE for consistency
Removed -Werror compiler flag from L2 test builds

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.

File	Description
.github/workflows/L2-tests.yml	Updates repository references to COMRPC development branches, fixes CMAKE_BUILD_TYPE variable, and removes -Werror flag
.github/workflows/L1-tests.yml	Updates repository references to COMRPC development branches for consistency with L2 tests

Copilot · 2026-01-15T08:53:37Z

          repository: rdkcentral/entservices-inputoutput
          path: entservices-inputoutput
-          ref: develop
+          ref: L2TestPlugin_COMRPC


The workflow is using a feature branch reference (L2TestPlugin_COMRPC) instead of a stable branch like develop or a tagged release. This is acceptable for development but should be changed to a stable branch before merging to production. Ensure this is intentional for testing purposes.

Suggested change

ref: L2TestPlugin_COMRPC

ref: develop

Copilot · 2026-01-15T08:53:38Z

          -include $GITHUB_WORKSPACE/entservices-testframework/Tests/mocks/essos-resmgr.h
          -include $GITHUB_WORKSPACE/entservices-testframework/Tests/mocks/HdmiCec.h
-          -Werror -Wall -Wno-unused-result -Wno-deprecated-declarations -Wno-error=format=
+          -Wall -Wno-unused-result -Wno-deprecated-declarations -Wno-error=format=


Removing -Werror from the compiler flags reduces build strictness and allows warnings to be ignored. This change should be documented in the PR description with justification, especially for production code. If temporary for development, ensure this is reverted before final merge.

Suggested change

-Wall -Wno-unused-result -Wno-deprecated-declarations -Wno-error=format=

-Wall -Wno-unused-result -Wno-deprecated-declarations

Copilot · 2026-01-15T08:53:38Z

          repository: rdkcentral/entservices-testframework
          path: entservices-testframework
-          ref: develop
+          ref: L2TestPlugin_COMRPC


The workflow is using a feature branch reference (L2TestPlugin_COMRPC) instead of a stable branch like develop or a tagged release. This is acceptable for development but should be changed to a stable branch before merging to production. Ensure this is intentional for testing purposes.

Copilot · 2026-01-15T08:53:38Z

          repository: rdkcentral/entservices-inputoutput
          path: entservices-inputoutput
-          ref: develop
+          ref: L2TestPlugin_COMRPC


The workflow is using a feature branch reference (L2TestPlugin_COMRPC) instead of a stable branch like develop or a tagged release. This is acceptable for development but should be changed to a stable branch before merging to production. Ensure this is intentional for testing purposes.

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

Copilot · 2026-01-29T14:55:28Z

          run: rm -rf $GITHUB_WORKSPACE/entservices-apis/jsonrpc/DTV.json



The L2-tests.yml workflow now includes a patch application step for entservices-apis (lines 182-186 in L2-tests.yml), but L1-tests.yml does not have a corresponding patch step after the entservices-apis checkout.

If the COMRPC changes require patching entservices-apis for L2 tests, consider whether L1 tests also need this patch applied. If L1 tests don't require the patch, this is acceptable, but it should be verified that the 'Test' branch reference and lack of patch application won't cause L1 test failures.

Suggested change

run: rm -rf $GITHUB_WORKSPACE/entservices-apis/jsonrpc/DTV.json

- name: Remove DTV.json from entservices-apis

if: steps.cache.outputs.cache-hit != 'true'

run: rm -rf "$GITHUB_WORKSPACE/entservices-apis/jsonrpc/DTV.json"

Copilot · 2026-01-29T14:55:29Z

+      - name: Apply patches entservices-apis
+        run: |
+          cd $GITHUB_WORKSPACE/entservices-apis
+          patch -p1 < $GITHUB_WORKSPACE/entservices-testframework/patches/comrpc-support-for-l2tests-plugin.patch


This patch application step references 'comrpc-support-for-l2tests-plugin.patch' which should exist in the entservices-testframework repository. However, the entservices-testframework checkout on line 117 still references 'develop' branch, not 'L2TestPlugin_COMRPC'. This creates a potential issue:

The patch file may not exist in the 'develop' branch but only in the 'L2TestPlugin_COMRPC' branch. This will cause the workflow to fail when it tries to apply a non-existent patch.

Either:

Update line 117 to checkout 'L2TestPlugin_COMRPC' branch of entservices-testframework, or

Ensure the patch file exists in the 'develop' branch of entservices-testframework before merging this change.

Suggested change

patch -p1 < $GITHUB_WORKSPACE/entservices-testframework/patches/comrpc-support-for-l2tests-plugin.patch

if [ -f "$GITHUB_WORKSPACE/entservices-testframework/patches/comrpc-support-for-l2tests-plugin.patch" ]; then

patch -p1 < "$GITHUB_WORKSPACE/entservices-testframework/patches/comrpc-support-for-l2tests-plugin.patch"

else

echo "Patch 'comrpc-support-for-l2tests-plugin.patch' not found in entservices-testframework/patches, skipping."

fi

Copilot · 2026-01-29T14:55:29Z

          -include $GITHUB_WORKSPACE/entservices-testframework/Tests/mocks/essos-resmgr.h
          -include $GITHUB_WORKSPACE/entservices-testframework/Tests/mocks/HdmiCec.h
-          -Werror -Wall -Wno-unused-result -Wno-deprecated-declarations -Wno-error=format=
+          -Wall -Wno-unused-result -Wno-deprecated-declarations -Wno-error=format=


The '-Werror' flag has been removed from the compiler flags. This flag treats all warnings as errors, which is an important quality control measure. Removing it means that code with warnings can now compile successfully, potentially allowing bugs or code quality issues to slip through.

If this removal is intentional (e.g., to work around warnings in new COMRPC code), it should be:

Clearly documented in the PR description

Considered temporary until the warnings are fixed

Re-evaluated to ensure it doesn't mask important issues

If the removal is not essential for COMRPC support, consider keeping '-Werror' to maintain code quality standards.

Suggested change

-Wall -Wno-unused-result -Wno-deprecated-declarations -Wno-error=format=

-Wall -Werror -Wno-unused-result -Wno-deprecated-declarations -Wno-error=format=

Copilot · 2026-01-29T14:55:29Z

          repository: rdkcentral/entservices-testframework
          path: entservices-testframework
-          ref: develop
+          ref: L2TestPlugin_COMRPC


The branch reference has been changed from 'develop' to 'L2TestPlugin_COMRPC', which appears to be a feature branch. Using feature branches in CI workflows can cause workflow failures once the feature branch is merged or deleted. Consider whether this should point to a stable branch like 'develop' or 'main', or if this change should be temporary and reverted before merging.

Copilot · 2026-01-29T14:55:30Z

          repository: rdkcentral/entservices-inputoutput
          path: entservices-inputoutput
-          ref: develop
+          ref: L2TestPlugin_COMRPC


The branch reference has been changed from 'develop' to 'L2TestPlugin_COMRPC', which appears to be a feature branch. Using feature branches in CI workflows can cause workflow failures once the feature branch is merged or deleted. Consider whether this should point to a stable branch like 'develop' or 'main', or if this change should be temporary and reverted before merging.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

github-actions · 2026-01-30T06:56:49Z

Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

1 out of 2 committers have signed the CLA.
✅ (smanes0213)[https://github.com/smanes0213]
❌ @MukeshkumarK
_{You can retrigger this bot by commenting recheck in this Pull Request.}_{Posted by the CLA Assistant Lite bot.}

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Copilot · 2026-01-30T06:59:47Z

          repository: rdkcentral/entservices-inputoutput
          path: entservices-inputoutput
-          ref: develop
+          ref: L2TestPlugin_COMRPC


The workflow is referencing a feature branch 'L2TestPlugin_COMRPC' instead of a stable branch like 'develop' or 'main'. Using feature branches in CI workflows is risky because:

Feature branches may be deleted or rebased after merging, breaking the workflow

It creates dependency on unmerged code changes

It makes the workflow non-reproducible

Consider merging the required changes from 'L2TestPlugin_COMRPC' branch into 'develop' first, then update this reference back to 'develop'. If this is temporary for testing purposes, ensure it's reverted before merging to develop.

Suggested change

ref: L2TestPlugin_COMRPC

ref: develop

Update L1 and L2 workflows to use CMAKE_BUILD_TYPE and L2TestPlugin_C…

b2be3ad

…OMRPC branch

smanes0213 requested a review from a team as a code owner January 7, 2026 08:53

smanes0213 added 6 commits January 7, 2026 14:35

Change entservices-apis checkout ref to Test branch in all workflows

47a6a99

Fix deprecated-declarations warnings treated as errors

dd6d655

Changed -Wno-deprecated-declarations to -Wno-error=deprecated-declarations to allow warnings from Thunder's VirtualInput.h without failing the build.

Suppress deprecated declarations warnings in workflows

b9dc1b2

Remove Werror flag

b2ac21b

Update L2-tests.yml

1f5ef9e

Remove Debug flag while building thunder

0c33fe9

smanes0213 requested a review from Copilot January 15, 2026 08:50

Copilot started reviewing on behalf of smanes0213 January 15, 2026 08:51 View session

Merge branch 'develop' into L2TestPlugin_COMRPC

6b21f93

Copilot AI reviewed Jan 15, 2026

View reviewed changes

mkumar705 and others added 2 commits January 29, 2026 18:18

Added patch file for L2 test plugins

12606d2

Merge branch 'develop' into L2TestPlugin_COMRPC

8e12d17

Copilot AI review requested due to automatic review settings January 29, 2026 14:51

Copilot started reviewing on behalf of smanes0213 January 29, 2026 14:51 View session

Copilot AI reviewed Jan 29, 2026

View reviewed changes

Apply suggestion from @Copilot

ff84669

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings January 30, 2026 06:56

Copilot started reviewing on behalf of MukeshkumarK January 30, 2026 06:56 View session

Apply suggestion from @Copilot

9d14fb1

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI reviewed Jan 30, 2026

View reviewed changes

Update L2-tests.yml

055413f

	-Wall -Wno-unused-result -Wno-deprecated-declarations -Wno-error=format=
	-Wall -Wno-unused-result -Wno-deprecated-declarations

		run: rm -rf $GITHUB_WORKSPACE/entservices-apis/jsonrpc/DTV.json

-          run: rm -rf $GITHUB_WORKSPACE/entservices-apis/jsonrpc/DTV.json
+      - name: Remove DTV.json from entservices-apis
+        if: steps.cache.outputs.cache-hit != 'true'
+        run: rm -rf "$GITHUB_WORKSPACE/entservices-apis/jsonrpc/DTV.json"

-          patch -p1 < $GITHUB_WORKSPACE/entservices-testframework/patches/comrpc-support-for-l2tests-plugin.patch
+          if [ -f "$GITHUB_WORKSPACE/entservices-testframework/patches/comrpc-support-for-l2tests-plugin.patch" ]; then
+            patch -p1 < "$GITHUB_WORKSPACE/entservices-testframework/patches/comrpc-support-for-l2tests-plugin.patch"
+          else
+            echo "Patch 'comrpc-support-for-l2tests-plugin.patch' not found in entservices-testframework/patches, skipping."
+          fi

	-Wall -Wno-unused-result -Wno-deprecated-declarations -Wno-error=format=
	-Wall -Werror -Wno-unused-result -Wno-deprecated-declarations -Wno-error=format=

Uh oh!

Conversation

smanes0213 commented Jan 7, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jan 30, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants