RDKEMW-18857 : Remove RDKCM_RDKE from all workflows#177
Merged
Conversation
Reason for change: RDKCM_RDKE secret is introduced to access entservices-testframework when its private. Now repo has been made as public. So, removing the RDKCM_RDKE secrets from all workflows. Test Procedure: refer ticket. Risks: Medium Priority: P2 version: Patch Signed-off-by: balaji velmurugan <balaji_velmurugan@comcast.com>
There was a problem hiding this comment.
Pull request overview
Removes the RDKCM_RDKE secret (previously needed to access the private entservices-testframework) from all workflows now that the repository is public. The secret is dropped from the L1 reusable workflow contract and its callers, from the native build job env, and from the component-release clone URL.
Changes:
- Drop
RDKCM_RDKEfromtests-trigger.ymlcaller and fromL1-tests.ymlreusable-workflowsecrets:block and itsentservices-testframeworkcheckout token. - Remove
GITHUB_TOKEN: ${{ secrets.RDKCM_RDKE }}from thenative_full_build.ymlbuild step. - Replace the authenticated
git cloneURL incomponent-release.ymlwith an unauthenticated HTTPS clone.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/tests-trigger.yml | Removes secrets: block passing RDKCM_RDKE to the reusable L1 workflow. |
| .github/workflows/L1-tests.yml | Removes RDKCM_RDKE from workflow_call secrets and from the entservices-testframework checkout; cleans a stale commented token line. |
| .github/workflows/native_full_build.yml | Removes the env: block that mapped GITHUB_TOKEN to RDKCM_RDKE. |
| .github/workflows/component-release.yml | Switches the manual project clone to plain HTTPS without the embedded x-access-token. |
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
srikanth-vv
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: RDKCM_RDKE secret is introduced to access entservices-testframework when its private.
Now repo has been made as public. So, removing the RDKCM_RDKE secrets from all workflows and updated tag creation to on demand instead of automatic creation.
Replace RDKCM_RDKE token with RDKCM_DEPLOY_KEY in component-release.yml
Test Procedure: refer ticket.
Risks: Medium
Priority: P2
version: Patch