RDKEMW-21739: Restore crashupload success marker logline for upload success path [8.6]#73
Open
gomathishankar37 wants to merge 2 commits into
Open
RDKEMW-21739: Restore crashupload success marker logline for upload success path [8.6]#73gomathishankar37 wants to merge 2 commits into
gomathishankar37 wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates rate-limiting behavior documentation/tests to explicitly treat the deny-window (/tmp/.deny_dump_uploads_till) as a global cooldown (blocking both minidumps and coredumps), while keeping the upload-count check minidump-only, and adjusts an upload success log line in the C uploader.
Changes:
- Added/updated L1 (gtest) and L2 (pytest + Gherkin + matrices) coverage to reflect global deny-window behavior for coredumps.
- Added a large functional test-case specification document for
uploadDumps.sh, plus OpenSpec documentation describing runtime/subsystem/integration models. - Modified a C upload success log line in
upload.c.
Reviewed changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
unittest/ratelimit_gtest.cpp |
Updates deny-window timestamp setup and adds a coredump deny-window blocking test. |
test/uploadDumps_TestCases.md |
Adds a comprehensive functional test case catalog for uploadDumps.sh. |
test/L2_TODO.md |
Adjusts TC wording to clarify minidump-only counter semantics. |
test/L2_TESTS.md |
Updates the applicability/implementation matrix to reflect global deny-window behavior. |
test/functional-tests/tests/test_ratelimit_allow.py |
Updates documentation text for TC-050 and deny-window semantics. |
test/functional-tests/tests/README.md |
Fixes wording and updates doc links to the new test-case document location. |
test/functional-tests/features/ratelimit.feature |
Clarifies scenario preconditions around deny-window inactivity for coredump TC-050. |
README.md |
Updates the L2 coverage link to point at test/L2_TESTS.md. |
openspec/subsystems/subsystem-analysis.md |
Adds subsystem responsibility analysis documentation. |
openspec/runtime/execution-model.md |
Adds a documented execution model for shell vs C runtime paths. |
openspec/integrations/client-integration-model.md |
Adds client/integration surface documentation and rate-limit state semantics. |
openspec/config.yaml |
Adds OpenSpec context/rules configuration for artifact generation. |
c_sourcecode/src/upload/upload.c |
Changes the upload success log line in the S3 PUT success path. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| TEST_F(RateLimitTest, RatelimitCheckUnified_RecoveryNotReached_BlockUpload) { | ||
| // Set recovery time in future | ||
| time_t future = time(NULL) + 600; | ||
| long future = (long)time(NULL) + 600L; |
|
|
||
| TEST_F(RateLimitTest, RatelimitCheckUnified_CoredumpType_RecoveryWindow_BlockUpload) { | ||
| // The recovery window is global, so coredumps are blocked while it is active. | ||
| long future = (long)time(NULL) + 600L; |
| else | ||
| { | ||
| CRASHUPLOAD_INFO("S3 %s Upload is successful\n", filepath); | ||
| CRASHUPLOAD_INFO("Upload is successful with TLS1.2 for %s\n", filepath); |
gomathishankar37
changed the title
gomathishankar37
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.