Skip to content

RDKEMW-21738: Restore crashupload success marker logline for upload success path [8.5]#72

Open
gomathishankar37 wants to merge 2 commits into
support/2.0.1from
topic/RDKEMW-21738
Open

RDKEMW-21738: Restore crashupload success marker logline for upload success path [8.5]#72
gomathishankar37 wants to merge 2 commits into
support/2.0.1from
topic/RDKEMW-21738

Conversation

@gomathishankar37

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings July 17, 2026 12:07
@gomathishankar37
gomathishankar37 requested a review from a team as a code owner July 17, 2026 12:07

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates crashupload’s upload-success logging and expands/organizes L2 functional test documentation and rate-limit coverage, including clarifying that the deny-window is a global cooldown affecting both minidumps and coredumps.

Changes:

  • Adjust upload success-path logging in the C uploader (upload_file()).
  • Extend unit test coverage for unified rate limiting (add coredump + active deny-window case).
  • Add/refresh L2 functional test artifacts: comprehensive shell-script TC catalog, applicability matrix, TODO tracker, feature spec, and test-suite README updates.

Reviewed changes

Copilot reviewed 12 out of 13 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
c_sourcecode/src/upload/upload.c Changes upload success log line in the S3 PUT success path.
unittest/ratelimit_gtest.cpp Updates deny-window timestamp creation type; adds coredump deny-window block test and clarifies comments.
test/uploadDumps_TestCases.md Adds large functional TC document for uploadDumps.sh behavior.
test/L2_TODO.md Adds L2 TODO tracker / summary for applicable TCs.
test/L2_TESTS.md Adds L2 applicability + coverage mapping matrix for the C implementation.
test/functional-tests/tests/test_ratelimit_allow.py Adds pytest L2 tests for rate-limit allow paths (TC-048/050/052–054/053).
test/functional-tests/tests/README.md Reworks README to index pytest L2 suite and map files to TC coverage.
test/functional-tests/features/ratelimit.feature Adds Gherkin feature spec for rate-limit scenarios.
README.md Updates coverage figures/targets and L2 module status table.
openspec/subsystems/subsystem-analysis.md Adds subsystem responsibility overview (OpenSpec).
openspec/runtime/execution-model.md Adds runtime execution model documentation (OpenSpec).
openspec/integrations/client-integration-model.md Adds integration/CLI model documentation (OpenSpec).
openspec/config.yaml Adds OpenSpec context/rules configuration.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread c_sourcecode/src/upload/upload.c
Comment thread unittest/ratelimit_gtest.cpp
Comment thread unittest/ratelimit_gtest.cpp
Comment thread test/L2_TODO.md
Comment thread test/L2_TESTS.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants