2.1.3 release changelog updates#71
Closed
satya200 wants to merge 6 commits into
Closed
Conversation
Release 2.1.2
* RDKEMW-19103: Onboard Crashupload repo to OpenSpec * Address review comments * Update Architecture Diagram * Update Architecture Diagram * Update config.yaml
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the 2.1.3 release documentation/test collateral around rate-limiting semantics, adds a large OpenSpec baseline documentation set, and includes a small runtime logging change plus a new unit test for the global deny-window behavior.
Changes:
- Add/refresh rate-limit test documentation and coverage matrices; add a new gtest case verifying coredumps are blocked during the global deny-window.
- Add OpenSpec baseline architecture/runtime documentation and OpsX skill/prompt scaffolding.
- Update release/license artifacts (CHANGELOG/LICENSE/NOTICE) and adjust a success log line in the upload path.
Reviewed changes
Copilot reviewed 30 out of 31 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| unittest/ratelimit_gtest.cpp | Adds a unit test asserting the deny-window blocks coredump uploads; minor timestamp type tweak. |
| test/uploadDumps_TestCases.md | Adds a comprehensive functional test case catalog for uploadDumps behavior. |
| test/L2_TODO.md | Updates TC phrasing for minidump-only counter semantics. |
| test/L2_TESTS.md | Updates applicability/implementation notes for TC-050/TC-051 semantics. |
| test/functional-tests/tests/test_ratelimit_allow.py | Clarifies docstring narrative for deny-window vs minidump counter checks. |
| test/functional-tests/tests/README.md | Fixes doc typos and corrects links to relocated test case docs/matrix. |
| test/functional-tests/features/ratelimit.feature | Clarifies TC-050 scenario preconditions and wording. |
| README.md | Updates L2 coverage reference link to point at test/L2_TESTS.md. |
| openspec/subsystems/subsystem-analysis.md | Adds subsystem responsibility analysis for crashupload components. |
| openspec/runtime/operational-deployment-model.md | Adds service/trigger and operational deployment model documentation. |
| openspec/runtime/execution-model.md | Adds C-path runtime execution model documentation. |
| openspec/runtime/component-catalog.md | Adds runtime component catalog for binary/scripts/triggers and dependencies. |
| openspec/project.md | Adds OpenSpec “baseline architecture dossier” entrypoint doc. |
| openspec/pipeline/crash-processing-pipeline.md | Adds end-to-end crash processing pipeline documentation. |
| openspec/integrations/client-integration-model.md | Adds integration surface and lifecycle documentation. |
| openspec/gaps/known-unknowns-and-validation.md | Adds baseline gaps/unknowns checklist for future changes. |
| openspec/gaps/change-readiness-matrix.md | Adds change readiness / risk matrix for future OpenSpec proposals. |
| openspec/diagrams/architecture-diagrams.md | Adds Mermaid diagrams for architecture/flow/state. |
| openspec/config.yaml | Adds OpenSpec context minimization/config guidance. |
| NOTICE | Adds OpenSpec attribution/license note. |
| LICENSE | Appends MIT license text for OpenSpec materials. |
| CHANGELOG.md | Adds 2.1.3 section entries. |
| c_sourcecode/src/upload/upload.c | Changes success log message emitted on successful upload. |
| .github/skills/openspec-propose/SKILL.md | Adds OpsX “propose” skill instructions. |
| .github/skills/openspec-explore/SKILL.md | Adds OpsX “explore” skill instructions. |
| .github/skills/openspec-archive-change/SKILL.md | Adds OpsX “archive change” skill instructions. |
| .github/skills/openspec-apply-change/SKILL.md | Adds OpsX “apply change” skill instructions. |
| .github/prompts/opsx-propose.prompt.md | Adds OpsX propose prompt content. |
| .github/prompts/opsx-explore.prompt.md | Adds OpsX explore prompt content. |
| .github/prompts/opsx-archive.prompt.md | Adds OpsX archive prompt content. |
| .github/prompts/opsx-apply.prompt.md | Adds OpsX apply prompt content. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| else | ||
| { | ||
| CRASHUPLOAD_INFO("S3 %s Upload is successful\n", filepath); | ||
| CRASHUPLOAD_INFO("Upload is successful with TLS1.2 for %s\n", filepath); |
Comment on lines
201
to
+205
| Assertions: | ||
| • exit(0) | ||
| • DENY_UPLOADS_FILE was NOT created by the rate limiter. | ||
| (For coredump ALLOW_UPLOAD path, set_time() is never called.) | ||
| • DENY_UPLOADS_FILE was NOT created by the rate limiter. | ||
| (This case validates the minidump counter bypass when deny-window | ||
| is absent; active deny-window behavior is validated separately.) |
Comment on lines
+203
to
+206
|
|
||
|
|
||
| MIT License | ||
|
|
Comment on lines
+7
to
+8
| #### [2.1.3](https://github.com/rdkcentral/crashupload/compare/2.1.2...2.1.3) | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.