VPAAMP-782 static Xcode analysis - potential null pointer dereference#1731
Merged
Conversation
Reason for Change: address handful of compilation warnings Signed-off-by: Philip Stroffolino <philip_stroffolino@cable.comcast.com>
…ation passed as uint32_t) Signed-off-by: Philip Stroffolino <philip_stroffolino@cable.comcast.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses Xcode static-analysis findings and compilation warnings by tightening integer writes in ISO BMFF box handling and adding null-guards around mCdaiObject usage in the MPD fragment collector.
Changes:
- Fix potential narrowing when writing 64-bit values into 32-bit fields (ISO BMFF box serialization).
- Adjust TRUN/TFHD sample-duration setter APIs and writes to better match underlying 32-bit box fields.
- Add
mCdaiObjectnull checks to prevent potential null dereferences in CDAI-related MPD flows.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| isobmff/isobmffbox.h | Updates TRUN/TFHD sample-duration setter signatures. |
| isobmff/isobmffbox.cpp | Adds explicit casts for 32-bit writes; updates setter implementations accordingly. |
| fragmentcollector_mpd.cpp | Adds null checks around mCdaiObject use to avoid potential dereference. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for Change: address handful of compilation warnings