Skip to content

Attach all sources in SendCopy for HLS muxed ts to work #1726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anshephe merged 7 commits into from
Jul 16, 2026
Merged

Attach all sources in SendCopy for HLS muxed ts to work #1726

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d76fb74
Addling logic to inject video first for muxed ts
anjali-syna Jul 14, 2026
7ad1fff
Revert tsprocessor changes and attach all the sources from SendCopy
anjali-syna Jul 14, 2026
dee3035
Fixing compilation issue
anjali-syna Jul 14, 2026
f9c7422
Adding more logs to trace subtitle flow
anjali-syna Jul 16, 2026
d77752d
Fixing compilation issue
anjali-syna Jul 16, 2026
b13513f
Removed unwanted code
anjali-syna Jul 16, 2026
885a4f3
Adding comments
anjali-syna Jul 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions direct-rialto/AampRialtoPlayer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -806,11 +806,18 @@ bool AampRialtoPlayer::SendCopy(
{
if (!source->isAttached())
{
AAMPLOG_INFO("Setting stream caps for mediaType=%d", static_cast<int>(mediaType));
// For HLS-TS the codec format is all that Rialto requires to set the stream caps.
MediaCodecInfo codecInfo{};
codecInfo.mCodecFormat = toGstStreamOutputFormat(source->format());
SetStreamCaps(mediaType, std::move(codecInfo));
// Attaching all sources to avoid deadlock with muxed HLS-TS which uses only one injection thread
// For HLS-TS, the codec format is all that Rialto requires to set the stream caps.
for (const auto& source2: m_sources)
{
if (source2 && !source2->isAttached())
{
AAMPLOG_INFO("Setting stream caps for mediaType=%d", static_cast<int>(source2->mediaType()));
MediaCodecInfo codecInfo{};
codecInfo.mCodecFormat = toGstStreamOutputFormat(source2->format());
SetStreamCaps(source2->mediaType(), std::move(codecInfo));
}
}
}

auto sharedBuffer =
Expand Down