VPAAMP-602: LLD video freeze#1712
Open
Reshma-JO07 wants to merge 1 commit into
Open
Conversation
Reshma-JO07
force-pushed
the
feature/VPAAMP-602
branch
6 times, most recently
from
July 16, 2026 11:20
f128d04 to
7a2f377
Compare
Vinish100
reviewed
Jul 17, 2026
| } | ||
| } | ||
| } | ||
| else if ((eTRACK_VIDEO == type) && !dlInfo->isInitSegment && |
Contributor
There was a problem hiding this comment.
Retry should be done internally in GetFile with a 100-200ms delay
| { | ||
| // Reset context values specific to each download attempt | ||
| context.ResetForNewDownload(); | ||
| if (resumeAttemptPending) |
Contributor
There was a problem hiding this comment.
This should be a separate feature. Not part of this
|
|
||
| } | ||
| bool isRetryableDnsFailure = | ||
| (res == CURLE_COULDNT_RESOLVE_HOST) && |
Contributor
There was a problem hiding this comment.
Retry on DNS resolve failure, never succeeds. That's the data we have so far.
| resumeAttemptPending = false; | ||
| } | ||
|
|
||
| int retryWaitMs = CalculateCurlRetryBackoffMs(res, downloadAttempt); |
Contributor
There was a problem hiding this comment.
Lets keep it simple. Fixed retry delay for now. There is only 1 retry, so there is no need for calculation here
| { | ||
| http_error = getOriginalCurlError(http_error); | ||
|
|
||
| if (http_error == 404 || http_error == 403 || |
Contributor
There was a problem hiding this comment.
the plan is to remove these conditions going forward
Reshma-JO07
force-pushed
the
feature/VPAAMP-602
branch
from
July 17, 2026 06:54
7a2f377 to
4e174ba
Compare
Reason for change: Rampdown when curl 56 occurs Test Procedure: updated in ticket Risks: Medium Signed-off-by: Reshma-JO07 <sreshmaraphaelk@gmail.com>
Reshma-JO07
force-pushed
the
feature/VPAAMP-602
branch
from
July 17, 2026 09:00
4e174ba to
14cce7f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Rampdown when curl 56 occurs
Test Procedure: updated in ticket
Risks: Medium