VPAAMP-737: Playback fails when played DASH VOD assets#1708
Merged
Conversation
Reason for change: If bandwidth has changed after async download job submitted & new IDX is not yet loaded (the transient window), fall back to the submission-time URL so URL and range stay paired. Signed-off-by: psiva01 <sivasubramanian.patchaiperumal@ltts.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a DASH SegmentBase transient ABR-switch window where an async media-segment download could pair a new-profile URL with an old-profile byte range, causing incorrect byte-range fetches and downstream demux failures.
Changes:
- Add a guarded URL selection fallback in
MediaStreamContext::DownloadFragment()to keep URL and byte-range paired when bandwidth changes butIDXis still cleared/not yet reloaded. - Add clarifying comment in the MPD fragment collector about SegmentBase parallel download behavior and where the URL/range race is handled.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| MediaStreamContext.cpp | Adds a submission-time bandwidth fallback for URL lookup when IDX is empty during an ABR switch to keep URL/range consistent. |
| fragmentcollector_mpd.cpp | Adds documentation clarifying SegmentBase parallel download behavior and pointing to the race fix location. |
Signed-off-by: psiva01 <sivasubramanian.patchaiperumal@ltts.com>
psiva01
changed the title
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
Author
|
@copilot implement this review comment - #1708 (comment) |
Reason for change: Added L1 tests to verify DASH Init & SegmentBase downloads are serialized Signed-off-by: psiva01 <sivasubramanian.patchaiperumal@ltts.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refines how SegmentBase content is fetched in the
StreamAbstractionAAMP_MPD::FetchFragmentmethod to address race conditions during asynchronous fragment downloads, especially during ABR (Adaptive Bitrate) profile switches. The main change ensures that all SegmentBase downloads (not just initialization segments) are handled synchronously to maintain consistency between the URL, IDX, and byte range, preventing partial fragment downloads that can confuse downstream parsers.Improvements to SegmentBase fragment handling: