VPAAMP-683 : add log to to check time taken between first frame to pipeline moved to PLAYING state#1695
Open
Gnanesha wants to merge 2 commits into
Open
VPAAMP-683 : add log to to check time taken between first frame to pipeline moved to PLAYING state#1695Gnanesha wants to merge 2 commits into
Gnanesha wants to merge 2 commits into
Conversation
…peline moved to PLAYING state Reason for change :A new log has been added to report the time elapsed between the first frame and the PLAYING state Test Procedure: See ticket Risks: low
Contributor
There was a problem hiding this comment.
Pull request overview
This PR (VPAAMP-683) aims to add a middleware log that reports the elapsed time between receiving the first video frame and the GStreamer pipeline transitioning to the PLAYING state, intended to be emitted only for “new tune” scenarios.
Changes:
- Added a first-frame steady-clock timestamp (
mFirstFrameTimeInMS) and reset points in the pipeline lifecycle. - Added “new tune” plumbing via a new
Configs::isNewTuneflag passed from AAMP into the middleware. - Added a PAUSED→PLAYING state-transition log that computes and prints the first-frame→PLAYING duration.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
priv_aamp.h |
Adds a new tune-related member on PrivateInstanceAAMP (currently redundant with existing IsNewTune()). |
priv_aamp.cpp |
Initializes the new mIsNewTune member to false. |
aampgstplayer.cpp |
Passes “new tune” state into middleware config (currently wired to mIsNewTune). |
middleware/InterfacePlayerRDK.h |
Adds Configs::isNewTune to gate the new timing log. |
middleware/InterfacePlayerPriv.h |
Adds first-frame timestamp storage in GstPlayerPriv. |
middleware/InterfacePlayerRDK.cpp |
Records first-frame timestamp and logs first-frame→PLAYING duration on PAUSED→PLAYING. |
…peline moved to PLAYING state Reason for change :A new log has been added to report the time elapsed between the first frame and the PLAYING state Test Procedure: See ticket Risks: low
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VPAAMP-683 : add log to to check time taken between first frame to pipeline moved to PLAYING state pipeline moved to PLAYING state
Reason for change :A new log has been added to report the time elapsed between the first frame and the PLAYING state Test Procedure: See ticket
Risks: low