Add ITestStateControl to thunderinterfaces/qa_interfaces#506
Closed
smanes0213 wants to merge 2 commits into
Closed
Add ITestStateControl to thunderinterfaces/qa_interfaces#506smanes0213 wants to merge 2 commits into
smanes0213 wants to merge 2 commits into
Conversation
….0.0 annotation; JsonGenerator auto-produces JTestStateControl.h Signed-off-by: smanes0213 <sankalpmaneshwar46@outlook.com>
smanes0213
requested review from
MFransen69,
bramoosterhuis,
sebaszm and
sramani-metro
July 6, 2026 11:34
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new QA interface (ITestStateControl) to ThunderInterfaces and assigns new interface IDs in qa_interfaces/QAIds.h so the interface can be exposed/consumed via the existing QA interface ID space.
Changes:
- Added
qa_interfaces/ITestStateControl.hdefining theITestStateControlQA interface and its notification sink. - Extended
qa_interfaces/QAIds.hwith new IDs forITestStateControland its notification interface.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| qa_interfaces/QAIds.h | Adds interface ID entries for ITestStateControl and its notification interface. |
| qa_interfaces/ITestStateControl.h | Introduces the new QA interface contract for controlling/querying plugin state and receiving state-change notifications. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.