Include only the necessary headers to avoid linking against the common library#341
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Windows build configuration for the DeviceInfo and securityagent libraries to prevent unintended linkage against common.lib by defining THUNDER_NO_COMMON_LIB in the affected Visual Studio projects.
Changes:
- Add
THUNDER_NO_COMMON_LIBtoPreprocessorDefinitionsfor all Win32/x64 Debug/Release configurations insecurityagent.vcxproj. - Add
THUNDER_NO_COMMON_LIBtoPreprocessorDefinitionsfor all Win32/x64 Debug/Release configurations inDeviceInfo.vcxproj.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Source/securityagent/securityagent.vcxproj | Defines THUNDER_NO_COMMON_LIB for all Win32/x64 Debug/Release builds to avoid accidental common.lib default-lib linkage. |
| Source/deviceinfo/DeviceInfo.vcxproj | Defines THUNDER_NO_COMMON_LIB for all Win32/x64 Debug/Release builds to avoid accidental common.lib default-lib linkage. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
VeithMetro
changed the title
sebaszm
self-requested a review
July 16, 2026 09:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.