RDKEMW-21222: Implement connection-level and session-level cleanup mechanisms

[kvfasil]

What

What does this PR add or remove?

Why

Why are these changes needed?

How

How do these changes achieve the goal?

Test

How has this been tested? How can a reviewer test it?

Checklist

• I have self-reviewed this PR
• I have added tests that prove the feature works or the fix is effective

[Copilot]

Pull request overview

This PR introduces distinct cleanup paths for WebSocket-connection disconnects vs app-session termination, aiming to prevent over-cleaning in secure-mode scenarios where multiple connections share a session.

Changes:

• Add connection-level vs session-level cleanup semantics via a new CleanupType and new cleanup_for_connection / cleanup_for_session APIs.
• Update disconnect handling to clean listeners/subscriptions by connection id (cid) instead of session id.
• Extend/adjust tests to validate correct listener cleanup in shared-session multi-connection scenarios.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
core/main/src/service/apps/delegated_launcher_handler.rs	Adds session-level endpoint cleanup on app session end.
core/main/src/service/apps/app_events.rs	Adds a regression test ensuring cid-based cleanup doesn’t remove other connections in the same session.
core/main/src/firebolt/firebolt_gateway.rs	Switches disconnect cleanup to cid-based listener + broker subscription cleanup.
core/main/src/broker/websocket_broker.rs	Updates cleaner channel to use CleanupType for cleanup signaling.
core/main/src/broker/thunder_broker.rs	Implements cid-based and session-based broker subscription cleanup logic; adjusts subscription keying behavior.
core/main/src/broker/endpoint_broker.rs	Introduces CleanupType, adds connection/session cleanup APIs, and updates tests accordingly.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

[Copilot]

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

core/main/src/broker/service_broker.rs:26

• trace! is imported from jsonrpsee::tracing, while the rest of this broker uses the ripple_sdk::log facade (error!/info!). This mixes two logging backends and can cause the new trace log to be dropped or configured differently than other broker logs. Prefer using ripple_sdk::log::trace for consistency across the codebase.

use crate::state::platform_state::PlatformState;
use jsonrpsee::tracing::trace;
use ripple_sdk::{
    api::{gateway::rpc_gateway_api::JsonRpcApiError, observability::log_signal::LogSignal},
    log::{error, info},
    service::service_message::{Id, ServiceMessage},

[Copilot]

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.

[Copilot]

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

core/main/src/broker/service_broker.rs:26

• ServiceBroker imports trace from jsonrpsee::tracing, but the rest of this crate appears to consistently use the ripple_sdk::log macros (e.g., many files import log::{..., trace}). Mixing logging frameworks can lead to inconsistent filtering/formatting. Prefer using ripple_sdk::log::trace here as well.

use jsonrpsee::tracing::trace;
use ripple_sdk::{
    api::{gateway::rpc_gateway_api::JsonRpcApiError, observability::log_signal::LogSignal},
    log::{error, info},
    service::service_message::{Id, ServiceMessage},

[Copilot]

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.

[Copilot]

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.

[github-actions]

Package	Line Rate	Health
core.main.src.firebolt	13%	❌
core.sdk.src.processor	9%	❌
core.main.src.processor.storage	0%	❌
core.main.src.service.apps	33%	❌
core.main.src.state.cap	42%	❌
core.sdk.src.service.mock_app_gw.appgw	0%	❌
core.sdk.src.api.gateway	69%	➖
core.main.src.bootstrap.extn	0%	❌
core.main.src.bootstrap	0%	❌
core.sdk.src.api.distributor	29%	❌
core.main.src	0%	❌
core.sdk.src.extn	76%	✔
core.tdk.src.utils	0%	❌
device.thunder_ripple_sdk.src.processors.events	0%	❌
core.main.src.firebolt.handlers	12%	❌
device.mock_device.src	56%	➖
core.main.src.service.ripple_service	9%	❌
core.main.src.broker.rules	78%	✔
core.sdk.src.api	44%	❌
core.sdk.src.api.observability	57%	➖
core.main.src.state	36%	❌
core.sdk.src.service.mock_app_gw	0%	❌
core.main.src.broker.thunder	37%	❌
core.sdk.src.extn.client	81%	✔
core.tdk.src.gateway	100%	✔
core.sdk.src.api.manifest	74%	➖
device.thunder_ripple_sdk.src.bootstrap	0%	❌
device.thunder_ripple_sdk.src.processors	19%	❌
core.main.src.bootstrap.manifest	0%	❌
core.main.src.processor	0%	❌
core.sdk.src.api.firebolt	85%	✔
core.main.src.broker	69%	➖
core.main.src.broker.test	90%	✔
core.sdk.src.extn.ffi	0%	❌
core.sdk.src.api.device	75%	✔
core.sdk.src.utils	58%	➖
core.main.src.service.extn	25%	❌
device.thunder_ripple_sdk.src.client	61%	➖
core.main.src.service	32%	❌
core.sdk.src.framework	64%	➖
core.sdk.src.manifest	0%	❌
device.thunder_ripple_sdk.src	13%	❌
core.main.src.utils	28%	❌
device.thunder_ripple_sdk.src.events	43%	❌
core.sdk.src.service	65%	➖
Summary	50% (21971 / 44183)	➖

Minimum allowed line rate is 48%

[Copilot]

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.