RDKB-65720: CCI crash during beacon data parsing#9
Open
rranga540 wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a CCI crash when parsing start_ap_data by removing SSID handling from the START_AP message path, so beacon head/tail data parsing no longer depends on SSID fields/offsets.
Changes:
- Removed
ssid/ssid_lenfrom thewlan_emu_cfg80211_start_ap_tmessage struct (non-5.15mod_src). - Stopped extracting/copying
NL80211_ATTR_SSIDinto theSTART_APmessage inmod_src/rdkfmac_netdev.c. - Stopped serializing SSID length/data in the
START_APchar-device payload inlinux_5.15/mod_src/rdkfmac_cdev.c.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| mod_src/wlan_emu_msg_data.h | Removes SSID fields from the START_AP message struct to align message layout with beacon parsing expectations. |
| mod_src/rdkfmac_netdev.c | Drops SSID attribute extraction when building START_AP message data. |
| linux_5.15/mod_src/rdkfmac_cdev.c | Updates START_AP message serialization to omit SSID fields, preventing downstream parsing offset issues. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Impacted Platforms: TXB7, TXB8, VXB10, SXB10
Reason for change: Failed to parse the start_ap_data
Test Procedure: Trigger any vapconfiguratio test case from cci.
Risks: Low
Priority: P2
Signed-off-by:RaviShankar.R_Rangaraj@comcast.com