RDKB-65811: Do not update rdk_vap_info in cache#1278
Open
bmilcz-comcast wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR prevents update_global_cache() from overwriting the cached rdk_wifi_vap_info_t entries with partially decoded (and pointer-containing) structures, which could otherwise corrupt internal state used when generating subdocs.
Changes:
- Removed
memcpy()ofrdk_wifi_vap_info_tinto the global cache. - Updated only the
existsandforce_applyflags in the cachedrdk_wifi_vap_info_tentries.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bmilcz-comcast
force-pushed
the
rdkb-65811-update-global-cache-fix
branch
from
July 17, 2026 15:30
b4830e8 to
97b04b9
Compare
Reason for change: update_global_cache updates rdk_vap_info structures, however due to the mixed use this is invalid. Decoders only partially fill these structs when decoding and if copied, these partially filled structs will fill rdk_vap_info in cache with invalid data. Moreover, these structs seem to be updated internally in OneWifi and will not be modified by external libraries - thus only cache updates it might need is if during application relevant flags are changed due to internal logic. This commit brings back previous implementation of cache sync in vap_svc_public update to not interfere with other platforms, however this needs to be reevaluated as it doesn't look like it fulfills the role properly. Test Procedure: Ensure OneWifi does not send back invalid data in subdocs. Risks:Medium Priority:P1 Signed-off-by: Brayan Milczarek <brayan_milczarek@comcast.com>
bmilcz-comcast
force-pushed
the
rdkb-65811-update-global-cache-fix
branch
from
July 17, 2026 15:55
97b04b9 to
6c08e39
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: update_global_cache updates rdk_vap_info structures, however due to the mixed use this is invalid. Decoders only partially fill these structs when decoding and if copied, these partially filled structs will fill rdk_vap_info in cache with invalid data. Moreover, these structs seem to be updated internally in OneWifi and will not be modified by external libraries - thus only cache updates it might need is if during application relevant flags are changed due to internal logic.
Test Procedure: Ensure OneWifi does not send back invalid data in subdocs.
Risks:Medium
Priority:P1