RDKBWIFI-520: EasyMesh - Fix OneWifi crash with AP Metrics reporting.#1277
Open
rakhilpe wants to merge 1 commit into
Open
RDKBWIFI-520: EasyMesh - Fix OneWifi crash with AP Metrics reporting.#1277rakhilpe wants to merge 1 commit into
rakhilpe wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes an EasyMesh AP Metrics reporting crash in OneWifi by hardening associated-station counting logic and correcting a radio index error check.
Changes:
- Added a NULL guard when reading
associated_devices_mapto prevent crashes during AP Metrics report creation. - Fixed an incorrect error check in
ap_metrics_collector_config()to validateradio_indexinstead of an unrelated variable.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Reason for change: Added NULL guard to prevent crash if associated_devices_map is NULL. Also addressed a wrong code comparison for radio index. Test Procedure: Ensure no crash issues with onewifi with AP Metrics reporting. Risks: Medium Priority: P1 Signed-off-by: Rakhil P E <rakhilpe001@gmail.com>
rakhilpe
force-pushed
the
em_crash_fix_jul17
branch
from
July 17, 2026 14:03
3915f29 to
9468ff0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Added NULL guard to prevent crash if associated_devices_map is NULL. Also addressed a wrong code comparison for radio index.
Test Procedure: Ensure no crash issues with onewifi with AP Metrics reporting.
Risks: Medium
Priority: P1