Skip to content

RDKBWIFI-520: EasyMesh - Fix OneWifi crash with AP Metrics reporting.#1277

Open
rakhilpe wants to merge 1 commit into
rdkcentral:developfrom
rakhilpe:em_crash_fix_jul17
Open

RDKBWIFI-520: EasyMesh - Fix OneWifi crash with AP Metrics reporting.#1277
rakhilpe wants to merge 1 commit into
rdkcentral:developfrom
rakhilpe:em_crash_fix_jul17

Conversation

@rakhilpe

Copy link
Copy Markdown
Contributor

Reason for change: Added NULL guard to prevent crash if associated_devices_map is NULL. Also addressed a wrong code comparison for radio index.
Test Procedure: Ensure no crash issues with onewifi with AP Metrics reporting.
Risks: Medium
Priority: P1

Copilot AI review requested due to automatic review settings July 17, 2026 13:23
@rakhilpe
rakhilpe requested a review from a team as a code owner July 17, 2026 13:23
@github-actions github-actions Bot added the community contribution Contributions from community. label Jul 17, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes an EasyMesh AP Metrics reporting crash in OneWifi by hardening associated-station counting logic and correcting a radio index error check.

Changes:

  • Added a NULL guard when reading associated_devices_map to prevent crashes during AP Metrics report creation.
  • Fixed an incorrect error check in ap_metrics_collector_config() to validate radio_index instead of an unrelated variable.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread source/apps/em/wifi_em.c Outdated
Copilot AI review requested due to automatic review settings July 17, 2026 13:43

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Reason for change: Added NULL guard to prevent crash if associated_devices_map is NULL. Also addressed a wrong code comparison for radio index.
Test Procedure: Ensure no crash issues with onewifi with AP Metrics reporting.
Risks: Medium
Priority: P1

Signed-off-by: Rakhil P E <rakhilpe001@gmail.com>
@rakhilpe
rakhilpe force-pushed the em_crash_fix_jul17 branch from 3915f29 to 9468ff0 Compare July 17, 2026 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community contribution Contributions from community.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants