[LTE-2973] Blaster Failure (#1196)#1276
Open
DharmalakshmiA wants to merge 1 commit into
Open
Conversation
* testing * Change error print to info print for blaster status
Contributor
There was a problem hiding this comment.
Pull request overview
Enables uploading WiFi Blast measurement results to QM for extender (XLE) clients even when the blast succeeds, aligning extender behavior with gateway uploads so successful results aren’t dropped.
Changes:
- Always upload single-client active measurement results for extender devices (previously skipped on success).
- Expose
active_msmt_status_to_str()via header so it can be used across compilation units. - Add a log line to record the active measurement status before upload.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| source/apps/blaster/wifi_single_client_msmt.c | Removes the “skip on success” condition for extender uploads and adds status logging. |
| source/apps/blaster/wifi_blaster.h | Exports active_msmt_status_to_str() for cross-file use. |
| source/apps/blaster/wifi_blaster.c | Makes active_msmt_status_to_str() non-static to match new external usage. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LTE-2973: Upload successful blast results for XLE clients
Reason for change:
Enable upload of successful WiFi Blast measurement results for XLE clients. Previously, the measurement data was not being sent to QM for successful blast executions on extender devices.
Test Procedure:
Triggered WiFi Blast on XLE clients.
Verified the logs sent successfully from onewifi to QM
Risks:
Low
Signed-off-by: Dharmalakshmi A [Dharmalakshmi_Annamalai@comcast.com]