Skip to content

RDKBWIFI-518: Report real device country code in EasyMesh device tran…#1275

Open
dkyncu wants to merge 1 commit into
rdkcentral:developfrom
dkyncu:fix_country_code
Open

RDKBWIFI-518: Report real device country code in EasyMesh device tran…#1275
dkyncu wants to merge 1 commit into
rdkcentral:developfrom
dkyncu:fix_country_code

Conversation

@dkyncu

@dkyncu dkyncu commented Jul 16, 2026

Copy link
Copy Markdown

…slation

The EasyMesh device translator hardcoded the device country to "US", so the actual regulatory country never propagated to the controller and Device.WiFi.DataElements Network.Device.{i}.CountryCode could not be reported.

Report the device's country from the radio config (via country_code_conversion) when building the device object, falling back to US only when it is unavailable.

@dkyncu
dkyncu requested a review from a team as a code owner July 16, 2026 17:33
Copilot AI review requested due to automatic review settings July 16, 2026 17:33

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the EasyMesh device translation so the reported device regulatory country code reflects the actual radio configuration (instead of being hardcoded to "US"), enabling the controller/data model to surface the real CountryCode.

Changes:

  • Populate em_device_info_t.country_code from decoded_params->radios[0].oper.countryCode via country_code_conversion().
  • Fall back to "US" when the country cannot be derived.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread source/webconfig/wifi_easymesh_translator.c Outdated
@Nikita-Hakai Nikita-Hakai added the community contribution Contributions from community. label Jul 16, 2026
Copilot AI review requested due to automatic review settings July 16, 2026 18:14
@dkyncu
dkyncu force-pushed the fix_country_code branch from a7ab63c to 428c0bf Compare July 16, 2026 18:14

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comment thread source/webconfig/wifi_easymesh_translator.c Outdated
…slation

The EasyMesh device translator hardcoded the device country to "US", so the
actual regulatory country never propagated to the controller and
Device.WiFi.DataElements Network.Device.{i}.CountryCode could not be reported.

Report the device's country from the radio config (via country_code_conversion)
when building the device object, falling back to US only when it is unavailable.

Signed-off-by: Durmus Koyuncu <durmus.kyncu.kd@gmail.com>
@dkyncu
dkyncu force-pushed the fix_country_code branch from 428c0bf to c02ea1e Compare July 16, 2026 18:43
Copilot AI review requested due to automatic review settings July 16, 2026 18:43

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community contribution Contributions from community.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants