Skip to content

BCOMB-3480: Client connectivity drop due to Gateway blocking Unencrypted frames#1261

Merged
gsathish86 merged 7 commits into
rdkcentral:developfrom
Raju-krish:develop
Jul 17, 2026
Merged

BCOMB-3480: Client connectivity drop due to Gateway blocking Unencrypted frames#1261
gsathish86 merged 7 commits into
rdkcentral:developfrom
Raju-krish:develop

Conversation

@Raju-krish

@Raju-krish Raju-krish commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Reason for change : DHCP discover gets dropped because STA sends it without encryption.
Proposed Fix : Disassociate the client if it doesn't have IP
Test Proceedure : 1) If STA sends unprotected frame without having IP should disassociate.
Priority: P0
Risks: Low

Depends on : rdkcentral/rdkb-halif-wifi#119 , rdkcentral/rdk-wifi-hal#786

…ted frames (rdkcentral#1245)

Reason for change : DHCP discover gets dropped because STA sends it without encryption.
Proposed Fix : Disassociate the client if it doesn't have IP
Test Proceedure : 1) If STA sends unprotected frame without having IP should disassociate.
Priority: P0
Risks: Low

Signed-off-by: Rajagopalaswamy M <mrajagopalaswamy@gmail.com>
@Raju-krish
Raju-krish requested a review from a team as a code owner July 14, 2026 09:38
Copilot AI review requested due to automatic review settings July 14, 2026 09:39

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses a client connectivity issue where unencrypted frames (notably DHCP Discover) are dropped, by reacting to a HAL “unencrypted frame drop” event and disassociating clients that appear to have no IP address.

Changes:

  • Adds a new HAL callback handler to process “frame dropped due to unencrypted” events.
  • Checks whether the client has an IPv4 address and, if not, triggers a disassociation.
  • Registers the new callback during Wi-Fi monitor initialization.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread source/stats/wifi_monitor.c
Comment thread source/stats/wifi_monitor.c
Copilot AI review requested due to automatic review settings July 14, 2026 22:17

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

Comment thread source/stats/wifi_monitor.c Outdated
Comment thread source/stats/wifi_monitor.c Outdated
Copilot AI review requested due to automatic review settings July 15, 2026 14:28

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

Comment thread source/stats/wifi_monitor.c Outdated
Comment thread source/core/wifi_events.c
Copilot AI review requested due to automatic review settings July 15, 2026 16:37

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

Comment thread source/stats/wifi_monitor.c
Copilot AI review requested due to automatic review settings July 16, 2026 12:40

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

Comment thread source/stats/wifi_monitor.c
Comment thread source/stats/wifi_monitor.c
Copilot AI review requested due to automatic review settings July 16, 2026 16:30

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

Comment thread source/stats/wifi_monitor.c Outdated
Comment thread source/core/wifi_events.c
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 16, 2026 22:38

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@Raju-krish

Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@gsathish86
gsathish86 merged commit 83b162c into rdkcentral:develop Jul 17, 2026
7 of 9 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 17, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants