macro_early_return#1256
Draft
bharathivelp wants to merge 1 commit into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors parts of wifi_decoder.c to accommodate early-return decode macros by moving repetitive JSON decoding blocks into helper functions and introducing a wrapper/impl split for ANQP decoding to centralize cJSON lifetime management.
Changes:
- Split
decode_anqp_object()into a wrapper +decode_anqp_object_impl()sopassPointStatsis always cleaned up in one place. - Extract per-entry decoding into helpers for radio channel stats, neighbor stats, associated device stats, and radio diagnostic stats.
- Reorder some decoding/allocations to reduce leak risk when decode macros return early.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bharathivelp
force-pushed
the
fix/macroearly
branch
from
July 17, 2026 10:26
7bae407 to
dd02bc8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.