RDKB-65853: Fixing coverity issue#1253
Open
navyasher wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses Coverity-reported issues primarily around resource management (cJSON/Jansson objects and heap allocations) in the webconfig encoding and multicomp subdoc processing paths.
Changes:
- Removes redundant/unsafe cJSON object handling in radio channel encoding.
- Adjusts OVSDB
whereclause lifetime management in Ignite config update flow. - Adds missing frees/deletes in multicomp webconfig handlers (cJSON_Print buffer, parsed root, detached sub-blobs, msgpack resources).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| source/webconfig/wifi_encoder.c | Removes an unused cJSON object creation and avoids deleting a NULL object on allocation failure. |
| source/db/wifi_db_apis.c | Removes json_decref(where) calls (consistent with ownership transfer in the OVSDB transaction builder). |
| source/core/wifi_multidoc_webconfig.c | Adds missing cleanup for cJSON_Print output, parsed roots, detached sub-blobs, and msgpack buffers/zones on success paths. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Reason for change: Fixing coverity issues. Test Procedure: Build should be successful and the regression test should also succeed Risks: Low Priority: P1 Signed-off-by: Navya_Sheregar@comcast.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Fixing coverity issues.
Test Procedure: Build should be successful and the regression test should also succeed
Risks: Low
Priority: P1
Signed-off-by: Navya_Sheregar@comcast.com