Add error handling for mid-parental-height functions #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add MAXIMUM_PARENTAL_HEIGHT_CM constant (260 cm) to validation_constants.py - Add comprehensive input validation to mid_parental_height() function: * Validate sex parameter (must be 'male' or 'female') * Validate maternal_height (None, type, range 50-260 cm) * Validate paternal_height (None, type, range 50-260 cm) - Add comprehensive input validation to mid_parental_height_z() function: * Validate reference parameter * Validate maternal_height (None, type, range 50-260 cm) * Validate paternal_height (None, type, range 50-260 cm) - Add 7 new test functions covering all validation scenarios - All tests pass (22,767 total tests) Fixes issue: mid-parental-height accepts impossible values
Member
|
Thanks for the contribution @FibrinLab! It looks fine from a code point of view however we will need to run this past the statisticians who advise us before merging. Hopefully won't take too long :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue: mid-parental-height accepts impossible values #53