Allow watching a file that didn't exist before#9
Open
davidthomaswood wants to merge 1 commit into
Open
Conversation
If a watch request fails because the file didn't exist, an `OSError` is correctly raised, but the alias remains in the list of requests. Therefore it isn't possible to catch the exception, and retry the watch request once the file has been created. This patch adds the watch request to the request queue after attempting to call `_setup_watch`, to ensure it doesn't get left in the queue if the setup fails.
|
I think the same should be done in the |
|
What I described seems to be a similar issue to the one mentioned in #2 |
|
@rbarrois hi, any chance this could be merged? |
|
Any updates? |
|
Is this project dead? no action for years. |
|
I copy original module and apply all PR changes for my copy. All works fine, but this really sad when i see no progress all this time |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a watch request fails because the file didn't exist, an
OSErroriscorrectly raised, but the alias remains in the list of requests.
Therefore it isn't possible to catch the exception, and retry the watch
request once the file has been created.
This patch adds the watch request to the request queue after attempting
to call
_setup_watch, to ensure it doesn't get left in the queue ifthe setup fails.