fix(types): allow string fail_existing for customers.create#467
Open
Sayansh2004 wants to merge 1 commit intorazorpay:masterfrom
Open
fix(types): allow string fail_existing for customers.create#467Sayansh2004 wants to merge 1 commit intorazorpay:masterfrom
Sayansh2004 wants to merge 1 commit intorazorpay:masterfrom
Conversation
Made-with: Cursor
Author
Hi — the BVT check asks for the Tested (with test doc) or TestingNotRequired label. This PR only updates TypeScript types and CHANGELOG for #463. Could a maintainer please add TestingNotRequired, and approve the pending workflows if needed? Thanks. |
Author
|
Hi — the BVT check asks for the Tested (with test doc) or TestingNotRequired label. This PR only updates TypeScript types and CHANGELOG for #463. Could a maintainer please add TestingNotRequired, and approve the pending workflows if needed? Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the TypeScript type for
fail_existingon customer create so callers can use string'0'/'1'in addition to boolean and numeric0/1, which matches what the Customers API accepts (see #463).Changes
lib/types/customers.d.ts: widenfail_existingand clarify JSDoc.dist/types/customers.d.ts: synced fromlibafter build.CHANGELOG.md: Unreleased note under the same style as previous entries.Testing
npm testlocally (build + mocha + nyc); all tests passed.customers.create({ ..., fail_existing: '0' })andfail_existing: '1'type-check without errors.Fixes #463