[index.html] Adding section animations using aos.js library#83
Open
amine-a11 wants to merge 2 commits intoraysan5:masterfrom
Open
[index.html] Adding section animations using aos.js library#83amine-a11 wants to merge 2 commits intoraysan5:masterfrom
index.html] Adding section animations using aos.js library#83amine-a11 wants to merge 2 commits intoraysan5:masterfrom
Conversation
raysan5
changed the title
index.html] Adding section animations using aos.js library
Author
|
Hi @raysan5, thank you for updating the branch and improving the pull request title! The AOS animations are working fine on my end. Is there anything else I need to do, or should I wait for the pull request to be merged? Let me know. Thanks! |
Owner
|
@amine-a11 thanks, I'm just considering the usefulness of this addition compared for the additional code complexity, maintenance cost and external dependency cost. I need to think about it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This pull request introduces AOS (Animate On Scroll) animations to the About page, utilizing the AOS library.
Implementation
Alternatives
If there are concerns about using external libraries, I am happy to implement similar animations using pure CSS and JavaScript. Just let me know your preference!
Demo
2024-09-22-16-37-00.mp4