Skip to content

Document that the sum in the examples is a parallel reduction#459

Open
marmistrz wants to merge 1 commit intorayon-rs:mainfrom
marmistrz:doc-sum-par
Open

Document that the sum in the examples is a parallel reduction#459
marmistrz wants to merge 1 commit intorayon-rs:mainfrom
marmistrz:doc-sum-par

Conversation

@marmistrz
Copy link
Copy Markdown
Contributor

No description provided.

Comment thread README.md
```

Note that the `sum()` call is not a sequential one. It is, precisely,
a logarithmic, tree-like reduction known from, for example, OpenMP.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate what you're trying to say, but it's worded a bit awkwardly, especially with two parentheticals. Can you try simplifying the second sentence?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I completely forgot about it. Is the change still relevant or should I go ahead simplifying it?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a new paragraph following the example you're describing, but I'm not sure if that leads the reader in the same direction that you're addressing. I'll let you look at the context to see if you think your addition is still needed. (My own familiarity makes it harder to judge what could be confusing for newcomers...)

@cuviper
Copy link
Copy Markdown
Member

cuviper commented May 30, 2018

Ping @marmistrz, did you get another chance to look? If we don't hear from you, I may try to reword this myself in a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants