Migrate public service routing to Envoy Gateway - #43
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Public HTTP deployments currently create NGINX Ingress objects. This migrates deployment and cleanup to Envoy Gateway HTTPRoute/GRPCRoute resources, preserving custom domains, stored preview hostnames, and the existing API/configuration fields.
envoy.nimbus.dev/*annotations. Supported NGINX keys remain deprecated aliases; conflicting settings and unknown Envoy keys are rejected.Validation: Go 1.25.1 race tests and vet passed. Generated HTTP, gRPC, SPA, auth, and CORS resources passed strict schema validation and offline Envoy 1.9.1 translation, including gRPC method matching and retries. Live browser sessions and deployments have not been exercised with this Nimbus version.
Nothing has been deployed. Rollout requires the configured Envoy Gateway/cert-manager integration and, for auth or SPA services, a digest-pinned image built from this Nimbus version in
NIMBUS_ROUTE_HELPER_IMAGE. Existing services migrate when redeployed; there is no startup-wide migration or transactional rollback. The README documents the shared Gateway's listener limit and deployment timeout considerations.