remove assertion when trying to re-enable active mode

[vshakitskiy]

Closes #39

[karlsson]

Should one do actor.continue only for the Ok(Nil) case and actor.stop for the Error(_) case ?

[vshakitskiy]

Should one do actor.continue only for the Ok(Nil) case and actor.stop for the Error(_) case ?

yep, that is the cleaner approach, the connection is already dead at Error case, so we should stop the actor then!

[rawhat]

Makes sense, thank you!

[karlsson]

I just wonder...
Now your error case is Error(Nil) which is what is defined for transport.set_opts but the called ffi function in glisten_{ssl,tcp}_ffi.erl seems to return the Erlang error which would be Error(Einval) in this case.
Maybe all the set_opts errors in the ffi modules should be mapped to Nil or that one specifies all possible error types for the set_opts call?

[vshakitskiy]

I just wonder... Now your error case is Error(Nil) which is what is defined for transport.set_opts but the called ffi function in glisten_{ssl,tcp}_ffi.erl seems to return the Erlang error which would be Error(Einval) in this case. Maybe all the set_opts errors in the ffi modules should be mapped to Nil or that one specifies all possible error types for the set_opts call?

You nailed it, I am receiving lots of crashes now. We are pattern matching on Error(Nil) which is not the case exactly. Internally we don't return {error, nil}!