Merged
Conversation
Replaced the existing `services.AddHttpClient<NswagConfiguration>()` setup with a more robust configuration that validates and sets the `BaseAddress` using the `JibanConstants.NswagBaseUrl` environment variable. Added a check to throw an `InvalidOperationException` if the `BaseAddress` is missing or empty. Retained existing message handlers and policies to ensure consistent behavior. This change improves maintainability and prevents runtime issues caused by missing configuration.
Simplified NSwag-generated clients by removing `NswagBase` and `NswagConfiguration` dependencies. Updated constructors to directly accept `HttpClient`. Removed `_baseUrl` logic from `NswagConfiguration`. Refactored `AddInfrastructureServices` to register a generic `HttpClient` and re-ordered service registrations. Updated `config.nswag` to remove `clientBaseClass` and `configurationClass` settings, ensuring direct `HttpClient` injection. These changes improve maintainability, reduce complexity, and streamline the dependency injection setup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.