Merged
Conversation
Moved the `services.AddScoped<ISriClient, SriClient>();` line in the `AddInfrastructureServices` method to occur just before the `return services;` statement. This adjustment ensures proper execution flow and aligns the service registration order for better maintainability.
Centralized NSwag client configuration by introducing `NswagBase` and `NswagConfiguration`, simplifying `HttpClient` and base URL management. Updated namespaces from `Jiban.Nswag` to `Jiban.Infrastructure.Nswag` for better alignment with the Infrastructure layer. Updated `Jiban.Multitenant` package to version `9.12.872`. Reorganized file structure by moving `Platform.cs` to the `Nswag` directory. Removed unused `using` directives and redundant properties like `BaseUrl` in generated clients. Updated `config.nswag` to use the new base class and configuration class, disable `BaseUrl` generation, and enable response wrapping with `SwaggerResponse`. Adjusted Swagger UI title in `Program.cs` to reflect branding changes. Improved maintainability, modularity, and consistency across the codebase.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.