Repository navigation
Refuse existing file stream wrappers - #149
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #148.
bypassFinals()now checks the stream metadata for its own PHP source and refuses whenfile://is already served by a user-space wrapper. This prevents silently unregistering Infection's include interceptor, including wrappers that leave Understudy's own source unchanged.The integration coverage now expects passive wrappers to be refused, and the README and guide describe the broader boundary.
Validation:
make buildpassed.make mutation-diff MUTATION_BASE=origin/mastergenerated no mutants because the changed bypass path is only exercised in subprocess integration scenarios, which are markedCoversNothing; the full build includes and passes those scenarios.