Repository navigation
Document what the adapter cannot give - #60
Merged
Merged
Conversation
Driving the engine through a single PHPUnit test method has consequences the READMEs did not name: lifecycle hooks and setUp/tearDown run once per property, test-double expectations are verified after the last run, and per-test coverage counts lines reached only while shrinking. The Testo adapter runs each trial through the framework's interceptor pipeline, so it does not share the first one — a difference users choosing between the adapters should know. Fixes #59
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #59
Driving the engine through a single PHPUnit test method has consequences the READMEs named only for
expectException(). The other three are now stated as well, in both languages and inllms.txt:setUp()/tearDown()and#[Before]/#[After]run once per property, not per run: state a run leaves behind is visible to the next run and to every shrinking attemptonce()fails the property as a whole and is never attributed to an input or shrunkThe Testo adapter does not share the first one, and that is stated too: there each trial goes through the framework's interceptor pipeline (
($this->next)($info)per run, with the lifecycle interceptor running the hooks inside that closure), so hooks run per run. Verified againstTestoTrialExecutorrather than taken from the issue text.Documentation only.
composer buildgreen (139 tests),bin/package-auditclean.