Repository navigation
A failed assertion is never the expected throw (0.9.2) - #55
Merged
Merged
Conversation
… it is an instance of (#54) The framework's assertion failure is an ordinary exception, so a wide expected class matched it and a property passed on a falsified body — T-1 on the new knob. The class is refused when the property is set up, naming why, and the executor never takes an assertion failure for the expected throw whatever class was named.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #54. The framework's assertion failure is an ordinary exception (Testo:
\LogicException; PHPUnit:\RuntimeExceptionthroughPHPUnit\Framework\Exception), so a wide expected class matched it and the property passed on a falsified body — T-1 on the new knob, reproduced in both adapters. Two halves: the class is refused when the property is set up (a failed assertion is an instance of it), and the executor never takes an assertion failure for the expected throw whatever class was named. Docs in README ×2, llms.txt; CHANGELOG 0.9.2.