Repository navigation
fix: psalm 6.20 inference on Ipv6Formatter - #168
Merged
Merged
Conversation
Psalm 6.20 no longer preserves non-empty-list through array_map(dechex(...), ...), so implode() stopped being inferred as non-empty-string and the declared @return non-empty-string tripped MoreSpecificReturnType. The invariant is unchanged (exactly 8 groups in, 8 strings out), so it is restated as a @var annotation instead of a suppression.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unblocks the dependabot CI-action PRs (#166, #167): their PHP 8.x checks fail in the psalm step — unrelated to the PR contents.
Psalm 6.20 (fresh
composer updatein CI) no longer preservesnon-empty-listthrougharray_map(dechex(...), ...): the inference of `` degraded toarray<string>, and `implode(':', )` stopped counting as `non-empty-string`, tripping `MoreSpecificReturnType`/`LessSpecificReturnStatement` against the declared `@return non-empty-string`.The invariant itself is unchanged — exactly
self::GROUPSgroups in, exactly that many hex strings out — so it is restated as a@varannotation on ``. No suppression, no baseline.composer buildon psalm 6.20.0: 1722 passed, 1 skipped (PASSED).