Repository navigation
Reduce schema compilation memory for large documents - #170
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
rasuvaeff
force-pushed
the
perf/165-avoid-resolver-rewalks
branch
2 times, most recently
from
October 7, 2026 21:34
32c5084 to
ae7d3e4
Compare
rasuvaeff
force-pushed
the
perf/165-avoid-resolver-rewalks
branch
from
October 7, 2026 21:56
ae7d3e4 to
ddc224b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially addresses #165
Stripe's spec3.json exhausted a 10 GiB PHP limit while compiling response schemas. Profiling showed monotonic growth from Opis schema graphs retained for every compiled root;
effectiveSchema()itself was not the dominant allocation site.This change:
Validation:
make build(946 tests, 4552 assertions)make rectorgit diff --checkThis improves peak memory, but does not yet meet the issue's single-digit-second target. Issue #165 remains open for that work.