Pico default xxx impl#3033

Merged

kilograham merged 10 commits into

pico-default-xxx-impl

Jun 30, 2026

kilograham commented Jun 26, 2026

Contributor

No description provided.

kilograham added 2 commits

June 26, 2026 17:17


          redo all PICO_DEFAULT_XXX_IMPL values so:

59c92b5

1. they can all be overriden
2. like pico_set_xxx_impl they expect to prefix pico_xxx_ to form the library name
3. for backwards compatibility if the value is already prefixed, then the prefix is not added a second time


          allow whitelist of mismatched PICO_CMAKE_CONFIG and PICO_BAZEL_CONFIG…

44db970

… options

kilograham added this to the 2.3.0 milestone

kilograham requested review from lurch and will-v-pi

June 26, 2026 22:32

kilograham commented Jun 26, 2026

Contributor Author

fixes #2912


          fix PICO_CMAKE_CONFIG

4bd5ed3

lurch reviewed

View reviewed changes

bazel/config/BUILD.bazel Outdated

lurch reviewed

View reviewed changes

src/CMakeLists.txt Outdated

lurch reviewed

View reviewed changes

src/rp2_common/pico_int64_ops/CMakeLists.txt Outdated

lurch reviewed

View reviewed changes

src/rp2_common/pico_bit_ops/CMakeLists.txt Outdated


          Apply suggestions from code review

65c5ef0

Co-authored-by: Andrew Scheller <lurch@durge.org>

lurch reviewed

View reviewed changes

src/rp2_common/pico_double/CMakeLists.txt Outdated

lurch reviewed

View reviewed changes

src/rp2_common/pico_divider/CMakeLists.txt Outdated

lurch reviewed

View reviewed changes

src/rp2_common/pico_double/include/pico/double.h Outdated

lurch reviewed

View reviewed changes

src/rp2_common/pico_double/include/pico/double.h Outdated

lurch reviewed

View reviewed changes

src/rp2_common/pico_double/include/pico/double.h Outdated

lurch reviewed

View reviewed changes

src/rp2_common/pico_float/CMakeLists.txt Outdated

lurch reviewed

View reviewed changes

src/rp2_common/pico_float/include/pico/float.h Outdated

lurch reviewed

View reviewed changes

src/rp2_common/pico_float/include/pico/float.h Outdated

lurch reviewed

View reviewed changes

src/rp2_common/pico_printf/CMakeLists.txt Outdated

lurch commented Jun 28, 2026

Contributor

double.h also has a bunch of comments saying

... out of range input except when using `pico_double_compiler`

so I guess that those will all want changing to

... out of range input except when using pico_double `compiler`

?

lurch reviewed

View reviewed changes

src/rp2_common/pico_double/include/pico/double.h Outdated

lurch reviewed

View reviewed changes

src/rp2_common/pico_double/include/pico/double.h Outdated

lurch commented Jun 28, 2026

Contributor

src/rp2_common/pico_stdio/stdio.c also has a comment saying:

 // PICO_STDIO_SHORT_CIRCUIT_CLIB_FUNCS=0 when using pico_printf_compiler)

so maybe that needs updating to

 // PICO_STDIO_SHORT_CIRCUIT_CLIB_FUNCS=0 when using pico_printf `compiler`)

?

kilograham and others added 5 commits

June 29, 2026 11:19


          Apply suggestions from code review

c45abc6

Co-authored-by: Andrew Scheller <lurch@durge.org>


          remove _ from prefix param to pico_fixup_default_impl

2ed9179


          what is different?

35bb2b1


          Line-ending fixes

a976197


          Fix a few missed renames

8af39e7

will-v-pi commented Jun 30, 2026

Contributor

double.h also has a bunch of comments saying
... out of range input except when using `pico_double_compiler`
so I guess that those will all want changing to
... out of range input except when using pico_double `compiler`
?

src/rp2_common/pico_stdio/stdio.c also has a comment saying:
 // PICO_STDIO_SHORT_CIRCUIT_CLIB_FUNCS=0 when using pico_printf_compiler)
so maybe that needs updating to
 // PICO_STDIO_SHORT_CIRCUIT_CLIB_FUNCS=0 when using pico_printf `compiler`)
?

I've pushed a fix for both of these

will-v-pi previously approved these changes

View reviewed changes


          Merge branch 'develop' into pico-default-xxx-impl

7cab3a9

kilograham dismissed will-v-pi’s stale review via

7cab3a9

June 30, 2026 14:17

will-v-pi approved these changes

View reviewed changes

kilograham merged commit 1d8c273 into develop

17 checks passed

kilograham deleted the pico-default-xxx-impl branch

June 30, 2026 15:03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet