Open
Conversation
lurch
reviewed
Jul 19, 2025
lurch
reviewed
Jul 19, 2025
i2c/lcd_1602_i2c/i2c_lcd.h
Outdated
| void i2c_lcd_writeString(i2c_lcd_handle inst, char* string); | ||
| void i2c_lcd_writeStringf(i2c_lcd_handle inst, const char* __restrict format, ...) _ATTRIBUTE ((__format__ (__printf__, 2, 3))); | ||
| void i2c_lcd_writeChar(i2c_lcd_handle inst, char c); | ||
| void i2c_lcd_writeLines(i2c_lcd_handle inst, char* line1, char* line2); |
Contributor
There was a problem hiding this comment.
This function-signature seems to be assuming that you're using a 16x2 LCD, and precludes the usage of a 20x4 LCD?
Author
There was a problem hiding this comment.
That's correct. The example name specifically says it's for 16x2. I also don't have 20x4 hardware to validate against.
lurch
reviewed
Jul 19, 2025
lurch
reviewed
Jul 19, 2025
lurch
reviewed
Jul 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improve the I2C LCD example in the following ways:
The following article was used as a reference for timing: https://web.alfredstate.edu/faculty/weimandn/lcd/lcd_initialization/lcd_initialization_index.html
This code has been tested on real hardware with a Pi Pico.
Fixes #654
Fixes #597