Skip to content

create_dmg.sh: prevent stale app version from being packaged #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
5739n4 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

create_dmg.sh: prevent stale app version from being packaged #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions create_dmg.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ set -e
APP_NAME="RuSwitcher"
# Единый источник версии — version.json в корне репозитория.
VERSION=$(/usr/bin/python3 -c "import json;print(json.load(open('version.json'))['version'])")
BUILD_VERSION=$(/usr/bin/python3 -c "import json;print(json.load(open('version.json')).get('build','1'))")
DMG_NAME="${APP_NAME}-${VERSION}.dmg"
# Keychain profile used for Apple notarization. Override with NOTARIZE_PROFILE=<name>.
# Skip notarization entirely with SKIP_NOTARIZE=1.
Expand All @@ -16,6 +17,28 @@ DMG_SIZE="10m"

echo "=== Creating styled DMG ==="

if [ ! -d "$APP_PATH" ]; then
echo "ERROR: $APP_PATH not found. Build the app first: ./build_app.sh"
exit 1
fi

APP_INFO_PLIST="$APP_PATH/Contents/Info.plist"
if [ ! -f "$APP_INFO_PLIST" ]; then
echo "ERROR: $APP_INFO_PLIST not found"
exit 1
fi

APP_VERSION=$(/usr/libexec/PlistBuddy -c "Print :CFBundleShortVersionString" "$APP_INFO_PLIST" 2>/dev/null || true)
APP_BUILD=$(/usr/libexec/PlistBuddy -c "Print :CFBundleVersion" "$APP_INFO_PLIST" 2>/dev/null || true)

if [ "$APP_VERSION" != "$VERSION" ] || [ "$APP_BUILD" != "$BUILD_VERSION" ]; then
echo "ERROR: App bundle version mismatch."
echo " version.json expects: $VERSION (build $BUILD_VERSION)"
echo " $APP_PATH contains: ${APP_VERSION:-?} (build ${APP_BUILD:-?})"
echo "Rebuild app before packaging: ./build_app.sh"
exit 1
fi

# Clean up
rm -f "$DMG_NAME" "$DMG_TEMP"

Expand Down