Add send/receive payload tracking for non-shuffle collectives - #1118
Merged
Conversation
Now that the communicator carries a Statistics object, we can plumb through basic communication volume statistics for the remaining collectives.
wence-
added
improvement
wence-
commented
Jul 2, 2026
3 tasks
wence-
commented
Jul 2, 2026
pentschev
reviewed
Jul 2, 2026
nirandaperera
left a comment
nirandaperera
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Thanks @wence-
madsbk
requested changes
Jul 3, 2026
madsbk
left a comment
madsbk
left a comment
Member
There was a problem hiding this comment.
Looks good beside a missing argument
wence-
force-pushed
the
wence/fea/more-coll-stats
branch
from
July 3, 2026 09:22
9a8a713 to
bda5ee8
Compare
wence-
force-pushed
the
wence/fea/more-coll-stats
branch
from
July 3, 2026 10:11
b5043a9 to
1297032
Compare
madsbk
approved these changes
Jul 3, 2026
pentschev
approved these changes
Jul 3, 2026
wence-
force-pushed
the
wence/fea/more-coll-stats
branch
from
July 3, 2026 13:39
d0c295c to
3530e42
Compare
wence-
force-pushed
the
wence/fea/more-coll-stats
branch
from
July 3, 2026 13:41
3530e42 to
a008f21
Compare
Contributor
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that the communicator carries a Statistics object, we can plumb through basic communication volume statistics for the remaining collectives.
Additionally, consistently take the statistics object from the communicator's progress thread when recording statistics for an object with a communicator.