Add writer_timezone option to the ORC writer - #23449
Draft
vuule wants to merge 1 commit into
Draft
Conversation
ORC timestamps are wall-clock values stored relative to the ORC epoch as it occurs in the writer's timezone, so writing them requires re-basing the encoded data, not just recording a name in the stripe footers. Add a writer_timezone option that does this, defaulting to UTC so existing output is unchanged.
github-actions
Bot
added
libcudf
vuule
added
feature request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a
writer_timezoneoption toorc_writer_optionsandchunked_orc_writer_options. ORC timestamps are wall-clock values stored relative to the ORC epoch as it occurs in the writer's timezone, so honoring the option re-bases the encoded data rather than only recording a name in the stripe footers, matching the base epoch that Apache'sTimestampTreeWriteruses. The default is"UTC", which leaves existing output byte-identical.For non-UTC files the legacy
minimum/maximumtimestamp statistics are omitted and onlyminimumUtc/maximumUtcare written, since readers interpret the legacy fields in their own timezone. Also exposed in the Java bindings.Addresses #23422.
Checklist