[REVIEW] nvImageCodec v0.7.0 infra only #997
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Pin nvimgcodec/nvimagecodec deps to 0.7.0 in deps/conda/pyproject - Make cuslide2 plugin a MODULE + add linkable core lib for tests - Avoid global include_directories; use target_include_directories
cdinea
added
improvement
Contributor
Author
|
/ok to test dff2e2b |
cdinea
changed the title
Contributor
Author
|
/ok to test 3897ea7 |
Make nvimgcodec dynlink include path PUBLIC on cuslide2_core so the MODULE plugin target can compile cuslide.cpp (includes headers that include <nvimgcodec.h>).
Contributor
Author
|
/ok to test a57cbb3 |
PyPI provides nvidia-nvimgcodec-cu13 as 0.7.0.11
Contributor
Author
|
/ok to test 71e9bf4 |
cdinea
changed the title
Contributor
Author
|
@jakirkham @KyleFromNVIDIA @gigony @grlee77 please review this PR that migrates to nvImageCodec v0.7.0 and adds the infra changes that @KyleFromNVIDIA requested on the second PR for nvImageCodec v0.6.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pinned nvimgcodec/nvimagecodec deps to 0.7.0 in deps/conda/pyproject
Made cuslide2 plugin a MODULE + add linkable core lib for tests
Avoided global include_directories; use target_include_directories