Repository navigation
fix: strip model-echoed render tags from tool-call arguments on every wire path (rebase of #934, Fixes #933) - #935
Merged
Conversation
… wire path #933: response-side tag stripping only covered text fields, so echoed <acp> refs inside tool-call arguments (OpenAI function.arguments, Anthropic input_json_delta, Responses function_call_arguments) reached clients verbatim and rendered in the host TUI. Strip is now structural (deep-scan of every string leaf) on streaming and non-streaming paths in both compression modes; ACP_RENDER_NONE is honored on all wire paths and documented. Rebased onto master 852b068; merge conflicts in src/plugin.ts and src/server.ts resolved (kept #728 localInputEstimate + ACP_RENDER_NONE gate; done-family arg/terminal split preserved). Fixes #933
Contributor
📦 Built Package ArtifactBranch: Option A — Install from npm PR tag (recommended)npm install -g billion-context@pr-935Each push to this PR publishes a new version under the Option B — Download artifact
tar xzf billion-context-pr935.tgz
npm install -g packageInstall instructions are refreshed on each push. |
Owner
Author
This was referenced Sep 18, 2026
Merged
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clean rebase of #934 (commit 8695aee) onto master 852b068 — #934 conflicted with master (
mergeable: false) and could not be merged as-is.What this fixes (#933)
Response-side tag stripping only covered text fields, so echoed
<acp>refs inside tool-call arguments (OpenAIfunction.arguments, Anthropicinput_json_delta, Responsesfunction_call_arguments) reached clients verbatim and rendered in the host TUI.ACP_RENDER_NONEis honored on all wire paths and documented in CONFIGURATION.md.tests/fix-933-tag-echo-toolargs.test.ts(305 lines).Conflict resolution (vs 8695aee)
src/plugin.ts: kept master's arg-carrier vs done-family split; done-family events now release held frames then strip/rewrite the completion frame itself; the dropped shared-tail block was re-implemented inside the completion branch.src/server.ts: merged master's [Bug] 上游从不报告 usage 时 nudge 永不触发——上下文无界增长直到超窗(ChatGPT 登录态后端) #728localInputEstimateblock with theACP_RENDER_NONErender-tags gate.Pre-flight
npm run typecheck✅npm test— 1850 tests, 0 fail (2 skip) ✅npm run build✅Closes #934 (superseded by this rebase). Fixes #933.