Skip to content

fix: strip model-echoed render tags from tool-call arguments on every wire path (rebase of #934, Fixes #933) - #935

Merged
ranxianglei merged 1 commit into
masterfrom
2026-09-22_rebase-934
Sep 18, 2026
Merged

ranxianglei merged 1 commit into
masterfrom
2026-09-22_rebase-934

Conversation

@ranxianglei

Copy link
Copy Markdown
Owner

Clean rebase of #934 (commit 8695aee) onto master 852b068 — #934 conflicted with master (mergeable: false) and could not be merged as-is.

What this fixes (#933)

Response-side tag stripping only covered text fields, so echoed <acp> refs inside tool-call arguments (OpenAI function.arguments, Anthropic input_json_delta, Responses function_call_arguments) reached clients verbatim and rendered in the host TUI.

  • Strip is now structural (deep-scan of every string leaf) on streaming and non-streaming paths, in both compression modes.
  • ACP_RENDER_NONE is honored on all wire paths and documented in CONFIGURATION.md.
  • New regression suite: tests/fix-933-tag-echo-toolargs.test.ts (305 lines).

Conflict resolution (vs 8695aee)

Pre-flight

  • npm run typecheck ✅
  • npm test — 1850 tests, 0 fail (2 skip) ✅
  • npm run build ✅

Closes #934 (superseded by this rebase). Fixes #933.

… wire path

#933: response-side tag stripping only covered text fields, so echoed <acp> refs inside tool-call arguments (OpenAI function.arguments, Anthropic input_json_delta, Responses function_call_arguments) reached clients verbatim and rendered in the host TUI. Strip is now structural (deep-scan of every string leaf) on streaming and non-streaming paths in both compression modes; ACP_RENDER_NONE is honored on all wire paths and documented.

Rebased onto master 852b068; merge conflicts in src/plugin.ts and src/server.ts resolved (kept #728 localInputEstimate + ACP_RENDER_NONE gate; done-family arg/terminal split preserved).

Fixes #933
@github-actions

Copy link
Copy Markdown
Contributor

📦 Built Package Artifact

Branch: 2026-09-22_rebase-934 (8a4c9c0)

Option A — Install from npm PR tag (recommended)

npm install -g billion-context@pr-935

Each push to this PR publishes a new version under the pr-935 npm tag.

Option B — Download artifact

  1. Download the artifact from the Actions run
  2. Extract the tarball and install:
tar xzf billion-context-pr935.tgz
npm install -g package

Install instructions are refreshed on each push.

@ranxianglei

Copy link
Copy Markdown
Owner Author

🤖 Powered by ework · qwen3.8-27b

[bot] 🏷 收到。这是 #934 的 rebase(头 8a4c9c0,base master@852b068,API 显示 mergeable=true / blocked)。我正在本地核对:拉取分支、对照 #934 原提交与 master 审查 diff 整洁度与冲突解决是否正确、跑 typecheck + 全量测试 + build,并确认 CI 状态。结论稍后回帖。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

opencode 插件模式下 render tag 注入消息正文,模型回显漏网后原样渲染进 TUI(元数据与正文同层问题)

1 participant